DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E86722084D
Date:   Thu, 4 Oct 2018 10:33:38 -0700
From:   Matthias Kaehlcke <mka@chromium.org>
To:     Sinan Kaya <okaya@codeaurora.org>
Cc:     Balakrishna Godavarthi <bgodavar@codeaurora.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Marcin Wojtas <mw@semihalf.com>,
        Andy Shevchenko Andy Shevchenko <andy.shevchenko@gmail.com>,
        Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
        Loic Poulain <loic.poulain@linaro.org>,
        Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH v4 1/2] Bluetooth: Add device_get_bd_address()
Message-ID: <20181004173338.GL22824@google.com>
References: <20180927004810.124185-1-mka@chromium.org>
 <20180927004810.124185-2-mka@chromium.org>
 <b28c34475e447cc29a139f9121b3c1d9@codeaurora.org>
 <e6752d4b-b22a-d951-e9db-1ae7445dc403@codeaurora.org>
 <20180927171305.GG22824@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180927171305.GG22824@google.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 27, 2018 at 10:13:05AM -0700, Matthias Kaehlcke wrote:
> On Thu, Sep 27, 2018 at 12:47:06PM -0400, Sinan Kaya wrote:
> > On 9/27/2018 12:41 PM, Balakrishna Godavarthi wrote:
> > >   void bt_sock_reclassify_lock(struct sock *sk, int proto);
> > > 
> > > +int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr);
> > 
> > Maybe change the API name to start with bt_ and get rid of device_?
> 
> device_ indicates that we get the BD_ADDR for a 'struct device' and
> not for e.g. a 'struct fwnode_handle'.
> 
> Anyway with this version of the patch fwnode_get_bd_address() has been
> scrapped and it might never be introduced again, so I'm open to change
> the name to bt_ if there is a general preference for it.

Marcel, can you live with this being added to the Bluetooth code base
instead of property? Also if you'd prefer the function to be named
bt_get_bd_address() let me know.

Cheers

Matthias