DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 073112064E
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: Re: [PATCH] Bluetooth: Rockchip: Give nodes for registering in the
 device tree
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20181014125014.3976-1-beagleboard@davidjohnsummers.uk>
Date:   Sun, 14 Oct 2018 19:51:40 +0200
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <F8F77105-FF67-4A23-BABE-7B0D70BD4DF5@holtmann.org>
References: <20181014125014.3976-1-beagleboard@davidjohnsummers.uk>
To:     David Summers <beagleboard@davidjohnsummers.uk>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi David,

> This patch adds the compatbility flags, so the Rockchip Bluetooth can
> be referenced in the device tree
> 
> Signed-off-by: David Summers <beagleboard@davidjohnsummers.uk>
> ---
> drivers/bluetooth/btrtl.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 7f9ea8e4c1b2..4cc89c9fe371 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -20,6 +20,8 @@
> #include <asm/unaligned.h>
> #include <linux/usb.h>
> 
> +#include <linux/of.h>
> +
> #include <net/bluetooth/bluetooth.h>
> #include <net/bluetooth/hci_core.h>
> 
> @@ -743,6 +745,21 @@ int btrtl_get_uart_settings(struct hci_dev *hdev,
> }
> EXPORT_SYMBOL_GPL(btrtl_get_uart_settings);
> 
> +static const struct of_device_id hci_rtl_of_match[] = {
> +	{ .compatible = "realtek,rtl8723a" },
> +	{ .compatible = "realtek,rtl8723bs" },
> +	{ .compatible = "realtek,rtl8723b" },
> +	{ .compatible = "realtek,rtl8723d" },
> +	{ .compatible = "realtek,rtl8723ds" },
> +	{ .compatible = "realtek,rtl8821a" },
> +	{ .compatible = "realtek,rtl8821c" },
> +	{ .compatible = "realtek,rtl8761a" },
> +	{ .compatible = "realtek,rtl8822b" },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, hci_rtl_of_match);

this makes no sense in btrtl.c driver. This needs to be in hci_h5.c and bound to h5_serdev_driver.

Regards

Marcel