DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C640F20835
Subject: Re: [PATCH] Bluetooth: Rockchip: Give nodes for registering in the
 device tree
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org
References: <20181014125014.3976-1-beagleboard@davidjohnsummers.uk>
 <F8F77105-FF67-4A23-BABE-7B0D70BD4DF5@holtmann.org>
From:   David Summers <beagleboard@davidjohnsummers.uk>
Message-ID: <a83b2172-0a83-988e-d09f-ad5a39720cc9@davidjohnsummers.uk>
Date:   Sun, 14 Oct 2018 21:16:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <F8F77105-FF67-4A23-BABE-7B0D70BD4DF5@holtmann.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Marcel,

On 14/10/2018 18:51, Marcel Holtmann wrote:
> Hi David,
>
>> This patch adds the compatbility flags, so the Rockchip Bluetooth can
>> be referenced in the device tree
>>
>> Signed-off-by: David Summers <beagleboard@davidjohnsummers.uk>
>> ---
>> drivers/bluetooth/btrtl.c | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
>> index 7f9ea8e4c1b2..4cc89c9fe371 100644
>> --- a/drivers/bluetooth/btrtl.c
>> +++ b/drivers/bluetooth/btrtl.c
>> @@ -20,6 +20,8 @@
>> #include <asm/unaligned.h>
>> #include <linux/usb.h>
>>
>> +#include <linux/of.h>
>> +
>> #include <net/bluetooth/bluetooth.h>
>> #include <net/bluetooth/hci_core.h>
>>
>> @@ -743,6 +745,21 @@ int btrtl_get_uart_settings(struct hci_dev *hdev,
>> }
>> EXPORT_SYMBOL_GPL(btrtl_get_uart_settings);
>>
>> +static const struct of_device_id hci_rtl_of_match[] = {
>> +	{ .compatible = "realtek,rtl8723a" },
>> +	{ .compatible = "realtek,rtl8723bs" },
>> +	{ .compatible = "realtek,rtl8723b" },
>> +	{ .compatible = "realtek,rtl8723d" },
>> +	{ .compatible = "realtek,rtl8723ds" },
>> +	{ .compatible = "realtek,rtl8821a" },
>> +	{ .compatible = "realtek,rtl8821c" },
>> +	{ .compatible = "realtek,rtl8761a" },
>> +	{ .compatible = "realtek,rtl8822b" },
>> +	{},
>> +};
>> +MODULE_DEVICE_TABLE(of, hci_rtl_of_match);
> this makes no sense in btrtl.c driver. This needs to be in hci_h5.c and bound to h5_serdev_driver.
>
> Regards
>
> Marcel
>
Now I'm confused. hci_h5.c looks like the general 3 wire uart connection 
to bluetooth, which probably covers sdio devices like the 8723bs which 
uses sdio.

But what of the 8723b, which looks like a typo earlier in the code for 
the 8723bu which is usb device. Or say the 8723be which is PCIe.

So if all sdio hci blue tooth cards should be specified with the 
hci_h5.c driver, and that is general 3 wire uart, then how should this 
be specified in the device tree?  Surely that should need a 
specification that says "hci uart", rather than a specific chip.

The btrtl.c code looks like it loads drivers, so is it that drivers 
aren't needed in the hci uart devices made by realtek?

Sorry if I'm being stupid here, but I'm confused ...

Thanks,

David.