DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D058120657
From:   Szymon Janc <szymon.janc@codecoup.pl>
To:     =?utf-8?B?xYF1a2Fzeg==?= Rymanowski 
        <lukasz.rymanowski@codecoup.pl>
Cc:     linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] btmon: Add colors to data status in extended adv report
Date:   Tue, 30 Oct 2018 10:21:53 +0100
Message-ID: <1719606.xSmM3C9bhQ@ix>
Organization: CODECOUP
In-Reply-To: <20181024101718.26695-1-lukasz.rymanowski@codecoup.pl>
References: <20181024101718.26695-1-lukasz.rymanowski@codecoup.pl>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi =C5=81ukasz,

On Wednesday, 24 October 2018 12:17:18 CET =C5=81ukasz Rymanowski wrote:
> This patch gives color indicators to data status in extended
> advertising reports. This gives better visibility on which advertising
> events were completed or truncated.
> ---
>  monitor/packet.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/monitor/packet.c b/monitor/packet.c
> index cf4a64362..eabd21914 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -9323,6 +9323,7 @@ static void print_ext_adv_report_evt_type(const char
> *indent, uint16_t flags) uint16_t props =3D flags;
>  	uint8_t data_status;
>  	const char *str;
> +	const char *color_on;
>  	int i;
>=20
>  	print_field("%sEvent type: 0x%4.4x", indent, flags);
> @@ -9343,19 +9344,23 @@ static void print_ext_adv_report_evt_type(const c=
har
> *indent, uint16_t flags) switch (data_status) {
>  	case 0x00:
>  		str =3D "Complete";
> +		color_on =3D COLOR_GREEN;
>  		break;
>  	case 0x01:
>  		str =3D "Incomplete, more data to come";
> +		color_on =3D COLOR_YELLOW;
>  		break;
>  	case 0x02:
>  		str =3D "Incomplete, data truncated, no more to come";
> +		color_on =3D COLOR_RED;
>  		break;
>  	default:
>  		str =3D "Reserved";
> +		color_on =3D COLOR_RED;
>  		break;
>  	}
>=20
> -	print_field("%s  Data status: %s", indent, str);
> +	print_field("%s  Data status: %s%s%s", indent, color_on, str, COLOR_OFF=
);
>=20
>  	if (mask)
>  		print_text(COLOR_UNKNOWN_ADV_FLAG,

Patch applied, thanks.

=2D-=20
pozdrawiam
Szymon Janc