DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16DC52087A
From:   Gal Ben-Haim <gbenhaim@augury.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     Gal Ben-Haim <gbenhaim@augury.com>
Subject: [PATCH BlueZ] core: Ignore SIGPIPE
Date:   Fri, 16 Nov 2018 21:14:52 +0200
Message-Id: <20181116191452.17377-1-gbenhaim@augury.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

bluetoothd receives a SIGPIPE and terminates if writing to a pipe that
was acquired by AcquireNotify and there are no readers. it can be
reproduced by terminating the reader process without closing the reader
end of the pipe.

Ignoring the SIGPIPE will cause the write operation to return an
error which will be logged as "io_send: Broken pipe".
---
 src/main.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/main.c b/src/main.c
index 4716f5388..c62886593 100644
--- a/src/main.c
+++ b/src/main.c
@@ -691,7 +691,7 @@ int main(int argc, char *argv[])
 	uint16_t sdp_mtu = 0;
 	uint32_t sdp_flags = 0;
 	int gdbus_flags = 0;
-	guint signal, watchdog;
+	guint signal_source, watchdog;
 	const char *watchdog_usec;
 
 	init_defaults();
@@ -721,7 +721,11 @@ int main(int argc, char *argv[])
 
 	event_loop = g_main_loop_new(NULL, FALSE);
 
-	signal = setup_signalfd();
+	signal_source = setup_signalfd();
+
+	/* Ignore SIGPIPE, a broken pipe error will be returned from write 
+	 * attempts to a pipe with no readers */
+	signal(SIGPIPE, SIG_IGN);
 
 	__btd_log_init(option_debug, option_detach);
 
@@ -809,7 +813,7 @@ int main(int argc, char *argv[])
 
 	sd_notify(0, "STATUS=Quitting");
 
-	g_source_remove(signal);
+	g_source_remove(signal_source);
 
 	plugin_cleanup();
 
-- 
2.19.1