DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D704E2080F
MIME-Version: 1.0
References: <20181117060024.10390-1-gbenhaim@augury.com> <CAHotPr82XDc9tE_76iknhQtbTjEMzXdQa4HpUy7asTZvwjG5ZQ@mail.gmail.com>
In-Reply-To: <CAHotPr82XDc9tE_76iknhQtbTjEMzXdQa4HpUy7asTZvwjG5ZQ@mail.gmail.com>
From:   Gal Ben Haim <gbenhaim@augury.com>
Date:   Sat, 17 Nov 2018 22:47:13 +0200
Message-ID: <CAHotPr9dh7Nz6St10D9LvEUDGrcM29_8CdGivanrw0qzVPb28Q@mail.gmail.com>
Subject: Re: [PATCH BlueZ] core: Catch SIGPIPE
To:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

i don't think it works at all... bluetoothd is still exiting with SIGPIPE.
i'm a bit lost with fixing this, I tried few methods that were
suggested here and the only one that actually worked is to ignore the
signal.

please advise how do you want to proceed with this..

On Sat, Nov 17, 2018 at 10:41 PM Gal Ben Haim <gbenhaim@augury.com> wrote:
>
> actually it does not log the broken pipe message, is it because errno
> isn't set before the signal handler is done?
> what do you think?
> On Sat, Nov 17, 2018 at 8:00 AM Gal Ben-Haim <gbenhaim@augury.com> wrote:
> >
> > bluetoothd receives a SIGPIPE and terminates if writing to a pipe that
> > was acquired by AcquireNotify and there are no readers. it can be
> > reproduced by terminating the reader process without closing the reader
> > end of the pipe.
> >
> > Catching SIGPIPE will cause the write call to return an EPIPE error
> > which will be logged as "io_send: Broken pipe".
> > ---
> >  src/main.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/src/main.c b/src/main.c
> > index 4716f5388..54cdb8d3f 100644
> > --- a/src/main.c
> > +++ b/src/main.c
> > @@ -533,6 +533,8 @@ static gboolean signal_handler(GIOChannel *channel, GIOCondition cond,
> >         case SIGUSR2:
> >                 __btd_toggle_debug();
> >                 break;
> > +       case SIGPIPE:
> > +               break;
> >         }
> >
> >         return TRUE;
> > @@ -549,6 +551,7 @@ static guint setup_signalfd(void)
> >         sigaddset(&mask, SIGINT);
> >         sigaddset(&mask, SIGTERM);
> >         sigaddset(&mask, SIGUSR2);
> > +       sigaddset(&mask, SIGPIPE);
> >
> >         if (sigprocmask(SIG_BLOCK, &mask, NULL) < 0) {
> >                 perror("Failed to set signal mask");
> > --
> > 2.19.1
> >