DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F8FA2086A
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.1 \(3445.101.1\))
Subject: Re: [PATCH BlueZ] core: Catch SIGPIPE
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <CABBYNZ+Nkbb2vUXVD6FY4+_ZJEqjgfXh=ONn7JYD9nyrx4E50Q@mail.gmail.com>
Date:   Mon, 19 Nov 2018 14:27:17 +0100
Cc:     gbenhaim@augury.com,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <7CA37768-A9C6-4241-82FD-51682EB50133@holtmann.org>
References: <20181117060024.10390-1-gbenhaim@augury.com>
 <CAHotPr82XDc9tE_76iknhQtbTjEMzXdQa4HpUy7asTZvwjG5ZQ@mail.gmail.com>
 <CAHotPr9dh7Nz6St10D9LvEUDGrcM29_8CdGivanrw0qzVPb28Q@mail.gmail.com>
 <CABBYNZ+Nkbb2vUXVD6FY4+_ZJEqjgfXh=ONn7JYD9nyrx4E50Q@mail.gmail.com>
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Luiz,

>> i don't think it works at all... bluetoothd is still exiting with SIGPIPE.
>> i'm a bit lost with fixing this, I tried few methods that were
>> suggested here and the only one that actually worked is to ignore the
>> signal.
>> 
>> please advise how do you want to proceed with this..
> 
> We might be better of switching to socketpair instead of pipe2 then,
> not only we can fix this problem using MSG_NOSIGNAL but also use
> sendmsg and setting auxiliary data which can be used to set things
> like the offset.

I agree, lets switch to socketpair. I have read up on handling SIGPIPE via signalfd and other means and it is just complicated.

Also we should include MSG_NOSIGNAL in all of our code and even switch the simple read/write to it.

Regards

Marcel