DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C39E8206B7
MIME-Version: 1.0
References: <20181129232426.5027-1-tedd.an@intel.com>
In-Reply-To: <20181129232426.5027-1-tedd.an@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 4 Dec 2018 22:06:15 +0200
Message-ID: <CABBYNZ+zM7gSrwLCB_dDijH=KQabRbLg5xNjtfc1YQCxnDQ=pA@mail.gmail.com>
Subject: Re: [PATCH] tools/btpclient: Fix compile warning with strncpy
To:     "An, Tedd" <tedd.an@intel.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Grzegorz Kolodziejczyk <grzegorz.kolodziejczyk@codecoup.pl>,
        ruslan.mstoi@intel.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Tedd,
On Fri, Nov 30, 2018 at 1:26 AM Tedd Ho-Jeong An <tedd.an@intel.com> wrote:
>
> This patch fixes the boundry warning-to-error in GCC 8.1.1 with strncpy.
> ---
>  tools/btpclient.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/btpclient.c b/tools/btpclient.c
> index b217df58f..e77720ed1 100644
> --- a/tools/btpclient.c
> +++ b/tools/btpclient.c
> @@ -376,8 +376,8 @@ static void btp_gap_read_info(uint8_t index, const void *param, uint16_t length,
>                 goto failed;
>         }
>
> -       strncpy((char *) rp.name, str, sizeof(rp.name));
> -       strncpy((char *) rp.short_name, str, sizeof(rp.short_name));
> +       snprintf((char *)rp.name, sizeof(rp.name), "%s", str);
> +       snprintf((char *)rp.short_name, sizeof(rp.short_name), "%s", str);
>         rp.supported_settings = L_CPU_TO_LE32(adapter->supported_settings);
>         rp.current_settings = L_CPU_TO_LE32(adapter->current_settings);
>
> --
> 2.17.2

Applied, thanks.

-- 
Luiz Augusto von Dentz