Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH v2] Bluetooth: hci_bcm: Handle specific unknown packets
 after firmware loading
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20181205212232.3947-1-pawel.mikolaj.chmiel@gmail.com>
Date:   Wed, 19 Dec 2018 00:49:49 +0100
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonathan Bakker <xc-racer2@live.ca>
Content-Transfer-Encoding: 8BIT
Message-Id: <6E62E2F9-5754-40AA-BA19-CDDABF338A1B@holtmann.org>
References: <20181205212232.3947-1-pawel.mikolaj.chmiel@gmail.com>
To:     =?utf-8?Q?Pawe=C5=82_Chmiel?= <pawel.mikolaj.chmiel@gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Pawel,

> The Broadcom controller on aries S5PV210 boards sends out a couple of
> unknown packets after the firmware is loaded.  This will cause
> logging of errors such as:
> 	Bluetooth: hci0: Frame reassembly failed (-84)
> 
> This is probably also the case with other boards, as there are related
> Android userspace patches for custom ROMs such as
> https://review.lineageos.org/#/c/LineageOS/android_system_bt/+/142721/
> Since this appears to be intended behaviour, treated them as diagnostic
> packets.
> 
> Note that this is another variant of commit 01d5e44ace8a
> ("Bluetooth: hci_bcm: Handle empty packet after firmware loading")
> 
> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> 
> ---
> Changes from v1:
> 	- Rename UNKNOWN to TYPE49
> 	- Rename UNKNOWN2 to TYPE52
> ---
> drivers/bluetooth/hci_bcm.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)

can you update this patch against latest bluetooth-next tree since it no longer applies cleanly.

Regards

Marcel