From:   =?utf-8?B?UGF3ZcWC?= Chmiel <pawel.mikolaj.chmiel@gmail.com>
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jonathan Bakker <xc-racer2@live.ca>
Subject: Re: [PATCH v2] Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading
Date:   Wed, 19 Dec 2018 12:26:16 +0100
Message-ID: <1616107.XVYD9PJAcy@acerlaptop>
In-Reply-To: <6E62E2F9-5754-40AA-BA19-CDDABF338A1B@holtmann.org>
References: <20181205212232.3947-1-pawel.mikolaj.chmiel@gmail.com> <6E62E2F9-5754-40AA-BA19-CDDABF338A1B@holtmann.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Dnia =C5=9Broda, 19 grudnia 2018 00:49:49 CET Marcel Holtmann pisze:
> Hi Pawel,
>=20
> > The Broadcom controller on aries S5PV210 boards sends out a couple of
> > unknown packets after the firmware is loaded.  This will cause
> > logging of errors such as:
> > 	Bluetooth: hci0: Frame reassembly failed (-84)
> >=20
> > This is probably also the case with other boards, as there are related
> > Android userspace patches for custom ROMs such as
> > https://review.lineageos.org/#/c/LineageOS/android_system_bt/+/142721/
> > Since this appears to be intended behaviour, treated them as diagnostic
> > packets.
> >=20
> > Note that this is another variant of commit 01d5e44ace8a
> > ("Bluetooth: hci_bcm: Handle empty packet after firmware loading")
> >=20
> > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
> > Signed-off-by: Pawe=C5=82 Chmiel <pawel.mikolaj.chmiel@gmail.com>
> >=20
> > ---
> > Changes from v1:
> > 	- Rename UNKNOWN to TYPE49
> > 	- Rename UNKNOWN2 to TYPE52
> > ---
> > drivers/bluetooth/hci_bcm.c | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
>=20
> can you update this patch against latest bluetooth-next tree since it no =
longer applies cleanly.
I've send new version of both patches (this and Bluetooth: hci_bcm: Handle =
specific unknown packets after firmware loading), rebased against latest bl=
uetooth-next.
>=20
> Regards
>=20
> Marcel
>=20