Date:   Mon, 24 Dec 2018 11:12:58 -0500
From:   Alexander Aring <aring@mojatatu.com>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     Alexander Aring <alex.aring@gmail.com>,
        Jukka Rissanen <jukka.rissanen@linux.intel.com>,
        linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] 6lowpan: fix debugfs_simple_attr.cocci warnings
Message-ID: <20181224161258.gvvq25k3ufuyt3ej@x220t>
References: <1545274433-146957-1-git-send-email-yuehaibing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1545274433-146957-1-git-send-email-yuehaibing@huawei.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi,

On Thu, Dec 20, 2018 at 02:53:53AM +0000, YueHaibing wrote:
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
> 
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
> 

Ok.

> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Alexander Aring <aring@mojatatu.com>

Reminder to myself: We should finally move this crap away which is even
not net namespace aware and introduce a stable uapi. I would love to see
it that it can be controlled by iproute2. :-)

- Alex