Date:   Thu, 10 Jan 2019 12:59:10 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     Pasi =?utf-8?B?S8Okcmtrw6RpbmVu?= <pasik@iki.fi>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: bluez: dbus method call for switching endpoint
Message-ID: <20190110115910.jldtfzzrhvta44pa@pali>
References: <20181215202910.j24amjshrvjqprll@pali>
 <CABBYNZLK4tyL8nvWbXxr6VctyEyJkMdwNiWMy4gUge9h9Vb4SQ@mail.gmail.com>
 <20181228191102.GA31975@reaktio.net>
 <CABBYNZ+bwbSkH4qtkuzhE=JY6KAGwJ_E4ABGT_LE6E277eTNDQ@mail.gmail.com>
 <20181229130818.jdcpwlpyoyhdqlf3@pali>
 <CABBYNZK4+K5vRF0JCHFcUjbfzWanp_ju6XfQQJWBtiLqKi=e7Q@mail.gmail.com>
 <20190108165612.5krhgtmce336xjx3@pali>
 <20190109180340.5fh7adag6buij4px@pali>
 <20190109181436.atlbhkqclpq3kcta@pali>
 <CABBYNZJk=wycGzic5+DqFHg=30KX9NNwnZMpsVdgkLjzseMA2g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CABBYNZJk=wycGzic5+DqFHg=30KX9NNwnZMpsVdgkLjzseMA2g@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On Thursday 10 January 2019 08:29:02 Luiz Augusto von Dentz wrote:
> Hi Pali,
>=20
> On Wed, Jan 9, 2019 at 3:14 PM Pali Roh=C3=A1r <pali.rohar@gmail.com> wro=
te:
> >
> > On Wednesday 09 January 2019 19:03:40 Pali Roh=C3=A1r wrote:
> > > On Tuesday 08 January 2019 17:56:12 Pali Roh=C3=A1r wrote:
> > > > On Tuesday 08 January 2019 13:44:24 Luiz Augusto von Dentz wrote:
> > > > > > > Regarding the API I still didn't have time to start it, so it=
 will
> > > > > > > take a little longer than I antecipated.
> > > > >
> > > > > Ive just sent the patches adding support to switch the endpoints,=
 Ive
> > > > > only tested with a couple of sony headsets so I would appreciate =
if
> > > > > you guys could try it as well. Note that the SetConfiguration must
> > > > > come from the same D-Bus connection as the endpoint that would be
> > > > > used, also if there is already an stream in place it must also be=
 from
> > > > > the same client since it would be terminated in the process, this=
 is
> > > > > to prevent entities fighting to configure with its own priority t=
hough
> > > > > usually we only PA endpoints, if you want to bypass this just for=
 now
> > > >
> > > > Great! Once patches would be ready I would look at my last A2DP
> > > > pulseaudio patches [1] and would try to implement switching, includ=
ing
> > > > support for bi-directional FastStream codec -- which can benefit fr=
om
> > > > it.
> > > >
> > > > [1] - https://lists.freedesktop.org/archives/pulseaudio-discuss/201=
8-July/030344.html
> > >
> > > Hi! I applied your 6 patches from https://marc.info/?l=3Dlinux-blueto=
oth&r=3D1&b=3D201901&w=3D2
> > > but whatever I did I was not able to locate in dbus hierarchy list of
> > > A2DP codecs supported by device.
> > >
> > > I thought that somewhere in
> > >
> > > qdbus --system org.bluez /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX
> > >
> > > I found A2DP codec capabilities...
> > >
> > > So how to get list of all supported A2DP codecs for particular device?
> >
> > Ah, I forgot to start bluetoothd with --experimental option. After that
> > I see sep*
> >
> > /
> > /org
> > /org/bluez
> > /org/bluez/hci0
> > /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX
> > /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/sep1
> > /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/sep3
> > /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/sep5
> >
> > and qdbus --system org.bluez /org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/sep1=
 org.freedesktop.DBus.Properties.GetAll org.bluez.MediaEndpoint1
> > list them correctly.
>=20
> You can use d-feet as well, btw did you forget to paste sep2 and sep4
> or the device just skip them?

No. This headset exports only sep1, sep3 and sep5. And supports SBC,
aptX and FastStream codecs. So count is correct, just numbering is not
canonical.

> Ive made sure not to filter any
> endpoints even if they would not have any matching local endpoints so
> we allow new endpoints to be registered later, anyway SetConfiguration
> actually checks that endpoints matches.
>=20

--=20
Pali Roh=C3=A1r
pali.rohar@gmail.com