Date:   Wed, 23 Jan 2019 18:54:48 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] tools/hcidump: Decode FastStream, aptX Low Latency, aptX
 HD and LDAC
Message-ID: <20190123175448.cdkdpnk6i5r4rzjs@pali>
References: <20190123174504.12350-1-pali.rohar@gmail.com>
 <8D9BABBE-2BBC-4BFE-BF7C-3BE24AF4DD10@holtmann.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="mw6qrruw7sdr4cyf"
Content-Disposition: inline
In-Reply-To: <8D9BABBE-2BBC-4BFE-BF7C-3BE24AF4DD10@holtmann.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk


--mw6qrruw7sdr4cyf
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
> Hi Pali,
>=20
> > ---
> > tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++=
++++---
> > 1 file changed, 55 insertions(+), 3 deletions(-)
> >=20
> > diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
> > index 18569c895..a21410f5a 100644
> > --- a/tools/parser/avdtp.c
> > +++ b/tools/parser/avdtp.c
> > @@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_=
t vndcodec)
> > {
> > 	if (vendor =3D=3D 0x0000004f && vndcodec =3D=3D 0x0001)
> > 		return "aptX";
> > +	else if (vendor =3D=3D 0x0000000a && vndcodec =3D=3D 0x0001)
> > +		return "FastStream";
> > +	else if (vendor =3D=3D 0x0000000a && vndcodec =3D=3D 0x0002)
> > +		return "aptX Low Latency";
> > +	else if (vendor =3D=3D 0x000000d7 && vndcodec =3D=3D 0x0024)
> > +		return "aptX HD";
> > 	else if (vendor =3D=3D 0x0000012d && vndcodec =3D=3D 0x00aa)
> > 		return "LDAC";
> > 	return "Unknown=E2=80=9D;
>=20
> lets keep the focus on btmon support since nobody should be using hcidump=
 anymore.

In btmon I already implemented it and patches are now merged. I just
found another place where this capability parsing is implemented and
based on fact that users still use hcidump I quickly looked at it and
implemented this parsing.

> Regards
>=20
> Marcel
>=20

--=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--mw6qrruw7sdr4cyf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCXEiqZgAKCRCL8Mk9A+RD
Uvd4AJ9hoY/F69pDIVQ8vf2mOa/Obftz0QCeKiZlZX7AwXZEfFhHy7sa8neW76M=
=gPTF
-----END PGP SIGNATURE-----

--mw6qrruw7sdr4cyf--