Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C7AC282C0 for ; Fri, 25 Jan 2019 07:56:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D6B621904 for ; Fri, 25 Jan 2019 07:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728534AbfAYH4u convert rfc822-to-8bit (ORCPT ); Fri, 25 Jan 2019 02:56:50 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:46165 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726735AbfAYH4u (ORCPT ); Fri, 25 Jan 2019 02:56:50 -0500 Received: from marcel-macpro.fritz.box (p4FF9FD60.dip0.t-ipconnect.de [79.249.253.96]) by mail.holtmann.org (Postfix) with ESMTPSA id 1C218CF172; Fri, 25 Jan 2019 09:04:35 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [PATCH 1/2] Bluetooth: Annotate implicit fall through in l2cap_config_rsp From: Marcel Holtmann In-Reply-To: <20190124180724.20910-1-malat@debian.org> Date: Fri, 25 Jan 2019 08:56:46 +0100 Cc: Gustavo Padovan , Johan Hedberg , "David S. Miller" , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <3DC0DB52-E3B0-42F3-BD4D-913FD77EDFBB@holtmann.org> References: <20190124180724.20910-1-malat@debian.org> To: Mathieu Malaterre X-Mailer: Apple Mail (2.3445.102.3) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Mathieu, > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > This commit removes the following warning: > > net/bluetooth/l2cap_core.c:4223:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Cc: Gustavo Padovan > Signed-off-by: Mathieu Malaterre > --- > net/bluetooth/l2cap_core.c | 1 + > 1 file changed, 1 insertion(+) the patches don’t apply cleanly against bluetooth-next tree. Please fix it up and resend. Regards Marcel