MIME-Version: 1.0
References: <20190124180724.20910-1-malat@debian.org> <3DC0DB52-E3B0-42F3-BD4D-913FD77EDFBB@holtmann.org>
In-Reply-To: <3DC0DB52-E3B0-42F3-BD4D-913FD77EDFBB@holtmann.org>
From:   Mathieu Malaterre <malat@debian.org>
Date:   Fri, 25 Jan 2019 09:08:41 +0100
Message-ID: <CA+7wUswPXAbsrNOUDUN4GMof7oV8pbxfcWLxXXZdx7DnBd4U5w@mail.gmail.com>
Subject: Re: [PATCH 1/2] Bluetooth: Annotate implicit fall through in l2cap_config_rsp
To:     Marcel Holtmann <marcel@holtmann.org>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc:     Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On Fri, Jan 25, 2019 at 8:56 AM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Mathieu,
>
> > There is a plan to build the kernel with -Wimplicit-fallthrough and
> > this place in the code produced a warning (W=1).
> >
> > This commit removes the following warning:
> >
> >  net/bluetooth/l2cap_core.c:4223:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >
> > Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > Signed-off-by: Mathieu Malaterre <malat@debian.org>
> > ---
> > net/bluetooth/l2cap_core.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> the patches don’t apply cleanly against bluetooth-next tree. Please fix it up and resend.

Never mind, both warnings are already fixed by:

6317950c1b9c Bluetooth: Mark expected switch fall-throughs

Sorry for the noise

> Regards
>
> Marcel
>