Date:   Wed, 30 Jan 2019 13:06:31 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To:     Pasi =?utf-8?B?S8Okcmtrw6RpbmVu?= <pasik@iki.fi>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] tools/hcidump: Decode FastStream, aptX Low Latency, aptX
 HD and LDAC
Message-ID: <20190130120631.usx67zjk4kmbhcla@pali>
References: <20190123174504.12350-1-pali.rohar@gmail.com>
 <8D9BABBE-2BBC-4BFE-BF7C-3BE24AF4DD10@holtmann.org>
 <20190123175448.cdkdpnk6i5r4rzjs@pali>
 <20190130081517.GI32745@reaktio.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190130081517.GI32745@reaktio.net>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On Wednesday 30 January 2019 10:15:17 Pasi Kärkkäinen wrote:
> On Wed, Jan 23, 2019 at 06:54:48PM +0100, Pali Rohár wrote:
> > On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
> > > Hi Pali,
> > > 
> > > > ---
> > > > tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++---
> > > > 1 file changed, 55 insertions(+), 3 deletions(-)
> > > > 
> > > > diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
> > > > index 18569c895..a21410f5a 100644
> > > > --- a/tools/parser/avdtp.c
> > > > +++ b/tools/parser/avdtp.c
> > > > @@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, uint16_t vndcodec)
> > > > {
> > > > 	if (vendor == 0x0000004f && vndcodec == 0x0001)
> > > > 		return "aptX";
> > > > +	else if (vendor == 0x0000000a && vndcodec == 0x0001)
> > > > +		return "FastStream";
> > > > +	else if (vendor == 0x0000000a && vndcodec == 0x0002)
> > > > +		return "aptX Low Latency";
> > > > +	else if (vendor == 0x000000d7 && vndcodec == 0x0024)
> > > > +		return "aptX HD";
> > > > 	else if (vendor == 0x0000012d && vndcodec == 0x00aa)
> > > > 		return "LDAC";
> > > > 	return "Unknown???;
> > > 
> > > lets keep the focus on btmon support since nobody should be using hcidump anymore.
> > 
> > In btmon I already implemented it and patches are now merged. I just
> > found another place where this capability parsing is implemented and
> > based on fact that users still use hcidump I quickly looked at it and
> > implemented this parsing.
> > 
> 
> I agree, hcidump still comes up on many places (guides, blogs, mailinglist posts, etc),
> so it makes sense to add these patches to hcidump aswell. Especially when the patch is quite small.

Exactly, people still use hcidump...

> 
> > > Regards
> > > 
> > > Marcel
> > > 
> > 
> > -- 
> > Pali Rohár
> > pali.rohar@gmail.com
> 
> 
> -- Pasi
> 

-- 
Pali Rohár
pali.rohar@gmail.com