MIME-Version: 1.0
References: <20190123174504.12350-1-pali.rohar@gmail.com> <8D9BABBE-2BBC-4BFE-BF7C-3BE24AF4DD10@holtmann.org>
 <20190123175448.cdkdpnk6i5r4rzjs@pali> <20190130081517.GI32745@reaktio.net> <20190130120631.usx67zjk4kmbhcla@pali>
In-Reply-To: <20190130120631.usx67zjk4kmbhcla@pali>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 30 Jan 2019 14:24:11 +0200
Message-ID: <CABBYNZJ5z_-8KiotL=9fkvq-gLPoqU1LJpaOBv1z4QfZiA3zaA@mail.gmail.com>
Subject: Re: [PATCH] tools/hcidump: Decode FastStream, aptX Low Latency, aptX
 HD and LDAC
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Cc:     =?UTF-8?B?UGFzaSBLw6Rya2vDpGluZW4=?= <pasik@iki.fi>,
        Marcel Holtmann <marcel@holtmann.org>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Pali, Pasi,
On Wed, Jan 30, 2019 at 2:09 PM Pali Roh=C3=A1r <pali.rohar@gmail.com> wrot=
e:
>
> On Wednesday 30 January 2019 10:15:17 Pasi K=C3=A4rkk=C3=A4inen wrote:
> > On Wed, Jan 23, 2019 at 06:54:48PM +0100, Pali Roh=C3=A1r wrote:
> > > On Wednesday 23 January 2019 18:46:18 Marcel Holtmann wrote:
> > > > Hi Pali,
> > > >
> > > > > ---
> > > > > tools/parser/avdtp.c | 58 +++++++++++++++++++++++++++++++++++++++=
++++++++++---
> > > > > 1 file changed, 55 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/tools/parser/avdtp.c b/tools/parser/avdtp.c
> > > > > index 18569c895..a21410f5a 100644
> > > > > --- a/tools/parser/avdtp.c
> > > > > +++ b/tools/parser/avdtp.c
> > > > > @@ -155,6 +155,12 @@ static char *vndcodec2str(uint32_t vendor, u=
int16_t vndcodec)
> > > > > {
> > > > >         if (vendor =3D=3D 0x0000004f && vndcodec =3D=3D 0x0001)
> > > > >                 return "aptX";
> > > > > +       else if (vendor =3D=3D 0x0000000a && vndcodec =3D=3D 0x00=
01)
> > > > > +               return "FastStream";
> > > > > +       else if (vendor =3D=3D 0x0000000a && vndcodec =3D=3D 0x00=
02)
> > > > > +               return "aptX Low Latency";
> > > > > +       else if (vendor =3D=3D 0x000000d7 && vndcodec =3D=3D 0x00=
24)
> > > > > +               return "aptX HD";
> > > > >         else if (vendor =3D=3D 0x0000012d && vndcodec =3D=3D 0x00=
aa)
> > > > >                 return "LDAC";
> > > > >         return "Unknown???;
> > > >
> > > > lets keep the focus on btmon support since nobody should be using h=
cidump anymore.
> > >
> > > In btmon I already implemented it and patches are now merged. I just
> > > found another place where this capability parsing is implemented and
> > > based on fact that users still use hcidump I quickly looked at it and
> > > implemented this parsing.
> > >
> >
> > I agree, hcidump still comes up on many places (guides, blogs, mailingl=
ist posts, etc),
> > so it makes sense to add these patches to hcidump aswell. Especially wh=
en the patch is quite small.
>
> Exactly, people still use hcidump...

Well it is a deprecated tool which we might remove starting on BlueZ
6.x which we would like to do in the very next release, if that
doesn't happen than perhaps Id take these patches in for a very last
BlueZ 5.x release.

@Marcel: Or you have a better plan? We could do one last 5.x and then
start working on removing the deprecated tools/etc.

> >
> > > > Regards
> > > >
> > > > Marcel
> > > >
> > >
> > > --
> > > Pali Roh=C3=A1r
> > > pali.rohar@gmail.com
> >
> >
> > -- Pasi
> >
>
> --
> Pali Roh=C3=A1r
> pali.rohar@gmail.com


--=20
Luiz Augusto von Dentz