Date:   Wed, 30 Jan 2019 21:08:43 -0800
From:   Myungho Jung <mhjungk@gmail.com>
To:     Johan Hovold <johan@kernel.org>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Add NULL check for tiocmget() and tiocmset()
Message-ID: <20190131050842.GA31677@myunghoj-Precision-5530>
References: <20190128065910.GA14959@myunghoj-Precision-5530>
 <20190130095938.GP3691@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190130095938.GP3691@localhost>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 30, 2019 at 10:59:38AM +0100, Johan Hovold wrote:
> On Sun, Jan 27, 2019 at 10:59:13PM -0800, Myungho Jung wrote:
> > tiocmget() and tiocmset() operations are optional and some tty drivers
> > like pty miss the operations. We need NULL check before referencing
> > them.
> 
> Good catch. I suggest splitting these fixes in two separate patches
> (after addressing Marcel's comments).
> 
> Don't forget to CC stable and add a Fixes-tag for each, as we we want to
> have this backported to stable.
> 
> > Reported-by: syzbot+a950165cbb86bdd023a4@syzkaller.appspotmail.com
> 
> Actually, these two bugs were never reported by sysbot AFAIKT so no need
> to give credit to anyone else here.
> 
> > Signed-off-by: Myungho Jung <mhjungk@gmail.com>
> > ---
> >  drivers/bluetooth/hci_ath.c   | 13 ++++++++-----
> >  drivers/bluetooth/hci_ldisc.c |  5 +++++
> >  2 files changed, 13 insertions(+), 5 deletions(-)
> 
> Johan

Hi Johan,

Thanks for reviewing my patch. This change is not directly related to the issue
that syzbot reported but the test will keep crashing without this fix because it
will finally reach ath_hci_uart_work(). I updated and resubmitted patch.

Thanks,
Myungho