Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: drivers/bluetooth/Kconfig BT_HCIUART_RTL depends on ACPI
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <9d693bec-56c7-58a1-67b8-ba9edd63989d@davidjohnsummers.uk>
Date:   Mon, 18 Feb 2019 11:48:12 +0100
Cc:     "open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <07109476-C017-4DC2-98A7-2EE5B53C4AB3@holtmann.org>
References: <9d693bec-56c7-58a1-67b8-ba9edd63989d@davidjohnsummers.uk>
To:     David Summers <beagleboard@davidjohnsummers.uk>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi David,

> On Arch Linux Arm, have a couple of people helping with the Tinker Board Patches - think we are close to something that may get passed.
> 
> Now testing it far more, and a snag, drivers/bluetooth/Kconfig contains:
> 
> config BT_HCIUART_RTL
>     bool "Realtek protocol support"
>     depends on BT_HCIUART
>     depends on BT_HCIUART_SERDEV
>     depends on GPIOLIB
>     depends on ACPI
>     select BT_HCIUART_3WIRE
>     select BT_RTL
> 
> But why does it depend on ACPI? I haven't found a way of setting that in 4.20, used to be in Power Management IIRC - but can't find now.
> 
> find . -name Kconfig -type f -exec grep "select ACPI" '{}' \;
> 
> Doesn't find anything to select ACPI …

initially we only supported Realtek chips that are described via ACPI. For DT based ones you need to extend this. The Broadcom ones uses this line:

depends on (!ACPI || SERIAL_DEV_CTRL_TTYPORT)

Maybe this works here as well.

Regards

Marcel