Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A86C43381 for ; Mon, 18 Feb 2019 22:08:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EEB3521479 for ; Mon, 18 Feb 2019 22:08:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731456AbfBRWIq (ORCPT ); Mon, 18 Feb 2019 17:08:46 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:60887 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729530AbfBRWIq (ORCPT ); Mon, 18 Feb 2019 17:08:46 -0500 Received: from oxbaltgw06.schlund.de ([172.19.246.12]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MjjGV-1hJKHD0Mkl-00lCIV; Mon, 18 Feb 2019 23:08:24 +0100 Date: Mon, 18 Feb 2019 23:08:21 +0100 (CET) From: Stefan Wahren To: Vasily Khoruzhick , Rob Herring Cc: Mark Rutland , devicetree , Johan Hedberg , Maxime Ripard , netdev@vger.kernel.org, Marcel Holtmann , linux-bluetooth@vger.kernel.org, Chen-Yu Tsai , "David S. Miller" , arm-linux , beagleboard@davidjohnsummers.uk Message-ID: <1245842044.588056.1550527701604@email.ionos.de> In-Reply-To: References: <20190118170232.16142-1-anarsoul@gmail.com> <20190118170232.16142-4-anarsoul@gmail.com> <20190218211035.GA28145@bogus> Subject: Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev47 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K1:hpiBGz7VzNd13L68dk3OIE0bSiUdUGgES2sdD0Ta2wZeLgL5O9P zb3uOfjlIVcJm2T021uSg53MjpH3YJg6q7/tlDVBD0ijj8Vdd08mMP+Hs3Qur5oEtESBuLj 4car7rYsT70uRdSsajUY2MhNLdUSJHMUNl4kGtre1OvF6sB2pg9GIenw8K7ujfSB++VpubN lYrKbpP8hBKIf1cd80Qow== X-UI-Out-Filterresults: notjunk:1;V03:K0:EoZFOG9CfBM=:31fPYIbn5PGOn6ENVizar8 qWenbuUUgl/rJFpH86fYCsbTpEqRXyMTD01AsTVNv0xXGoixRxI9Uh1dDUoxfh9VMc/gGtcSY 8+8pOSNqVLE042BO7rboeaAv4Ek1BoJokqO3d+E0LTL13JZrJyOmWGoujg6p28HtfCu3GjoNB kmyCjcRCbDPkCHyg6kU4tOCuFsTemNwhhQHuYbin21OdTNxgemqhgIvDJ3+QzBW1XllADJ/rS Sd8tRiMeqknS8IUBoLrsgYqw4VAo1SDmGWcKPAwdBA74A7qYiY7EK/tnb4ZX/0WB+Fe3F/EKH joyjdqAAAjlAzuKEAjFl/1EW9PglO3cHw6w7kWrlVYSffGzohDIBppHT0iyG9QOCpphmOMGac FNr7ztrLsJiWyaRT4nSXsXTL75w7BtktaPWCT1y3fxR62yBir7gzW+EsnUGAnC2GCMbpEwRO8 NUmMBn6RHODL5L4VQ7SsmiXrS8+nMqPOSfVLIZFmlv7O3PyYYz+KKQ9M0fFdJaRKuui+/ynRj xGEc+gLsQqqNT35+u3IcA7tshfoEpyNokYQHpBIP1enT2XpID6hkV204YYVQG52HpyrhxjJTK 19pP+nD3tls7uyHwGnCGeNX8nNF2Nw0Fn/XtbiyPRITJjYJZ1teSVZSOUFowcUJ7SPmDA+Hc1 ntTpit5YyDaK8UR8eYm/4ejYJUAJ5r6cMmiAMf1Bi+vkDrRKUP1K5MGoYEOXH1akKfOK7yb2i PH/MOippCldM4DI/p1Ci5vsvIKI82veH7yzDF6Nw68C22H+i4SmGUnRNkHw= Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Vasily, > Vasily Khoruzhick hat am 18. Februar 2019 um 22:24 geschrieben: > > > On Mon, Feb 18, 2019 at 1:10 PM Rob Herring wrote: > > > > On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhick wrote: > > > Add binding document for bluetooth part of RTL8723BS/RTL8723CS > > > > > > Signed-off-by: Vasily Khoruzhick > > > --- > > > .../bindings/net/rtl8723bs-bluetooth.txt | 35 +++++++++++++++++++ > > > 1 file changed, 35 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt > > > > > > diff --git a/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt b/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt > > > new file mode 100644 > > > index 000000000000..8357f242ae4c > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt > > > @@ -0,0 +1,35 @@ > > > +RTL8723BS/RTL8723CS Bluetooth > > > +--------------------- > > > + > > > +RTL8723CS/RTL8723CS is WiFi + BT chip. WiFi part is connected over SDIO, while > > > +BT is connected over serial. It speaks H5 protocol with few extra commands > > > +to upload firmware and change module speed. > > > + > > > +Required properties: > > > + > > > + - compatible: should be one of the following: > > > + * "realtek,rtl8723bs-bt" > > > + * "realtek,rtl8723cs-bt" > > > +Optional properties: > > > + > > > + - device-wake-gpios: GPIO specifier, used to wakeup the BT module (active high) > > > + - enable-gpios: GPIO specifier, used to enable the BT module (active high) > > > + - host-wake-gpios: GPIO specifier, used to wakeup the host processor (active high) > > > + - firmware-postfix: firmware postfix to be used for firmware config > > sorry, i didn't noticed your great series before. David and i working at the same stuff but for the Asus Tinker Board. I created a similiar yet untested patch version for hci_h5 [1]. Maybe it's useful. Just a comment about the binding. It's really necessary to add the reset-gpio? Can't we use the enable-gpio with inverse polarity for this? Stefan