Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3FB1C43381 for ; Sat, 23 Feb 2019 20:16:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62C9720675 for ; Sat, 23 Feb 2019 20:16:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=davidjohnsummers.uk header.i=@davidjohnsummers.uk header.b="hS4FCbSM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726252AbfBWUQW (ORCPT ); Sat, 23 Feb 2019 15:16:22 -0500 Received: from mail-gw.thundercloud.uk ([149.255.60.82]:33329 "EHLO mail-gw.thundercloud.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbfBWUQW (ORCPT ); Sat, 23 Feb 2019 15:16:22 -0500 Received: from mailbsf01.thundercloud.uk (mail-gw.thundercloud.uk [149.255.60.72]) by mail-gw.thundercloud.uk (Postfix) with ESMTPS id 4258160836C7 for ; Sat, 23 Feb 2019 20:16:21 +0000 (GMT) X-ASG-Debug-ID: 1550952980-05541312665cace0001-Y6scnF Received: from cloud706.unlimitedwebhosting.co.uk (no-dns-yet.unlimited.uk.net [149.255.62.7]) by mailbsf01.thundercloud.uk with ESMTP id 8s4rlgJrrT8cyOmX (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 23 Feb 2019 20:16:20 +0000 (GMT) X-Barracuda-Envelope-From: beagleboard@davidjohnsummers.uk X-Barracuda-Effective-Source-IP: no-dns-yet.unlimited.uk.net[149.255.62.7] X-Barracuda-Apparent-Source-IP: 149.255.62.7 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=davidjohnsummers.uk; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=flkXInH2rl5OXEAI4VVU2d30bYLJKnsg9y+YdC5LLF0=; b=hS4FCbSM/7E2rdPl/OjSWredHW ZAUJYeO+7kVIRWgzzVCe/NbgD31klUo9iD2gmm9TZipbPPTTtxu7s6qy8knruDNkih4vBXW9yZcIe +KcXkD5JLGm8lAXTIJ8MUkIN0OTW9Vliitg/ZVU9W+q990mD0SS/8cLDTAcu6wbReFKPrUiLQroNo kMokO1x0hg8hsTat60teP5Fxn8E7vk6WZDOdR5En9pOQyQqFBsKSQdwviCGc02VFPov/phRCOP7Hh Fmby3iT5O9EkovKk9q+AkOwRyNFreLLPgzoOobpZ2X1mMbT3RKOph6aTo0i8BJrJkHZhMkm+r2lYd un2fO9HA==; Received: from [87.114.170.31] (port=36704 helo=[192.168.2.187]) by cloud706.unlimitedwebhosting.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gxdid-0007AL-3R; Sat, 23 Feb 2019 20:16:19 +0000 Subject: Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth To: Vasily Khoruzhick X-ASG-Orig-Subj: Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth Cc: Stefan Wahren , Rob Herring , Mark Rutland , devicetree , Johan Hedberg , Maxime Ripard , netdev , Marcel Holtmann , "open list:BLUETOOTH DRIVERS" , Chen-Yu Tsai , "David S. Miller" , arm-linux References: <20190118170232.16142-1-anarsoul@gmail.com> <20190118170232.16142-4-anarsoul@gmail.com> <20190218211035.GA28145@bogus> <1245842044.588056.1550527701604@email.ionos.de> <8b97f349-4416-058c-0d01-3be592b89a7d@davidjohnsummers.uk> From: David Summers Message-ID: Date: Sat, 23 Feb 2019 20:16:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-PH X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud706.unlimitedwebhosting.co.uk X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - davidjohnsummers.uk X-Get-Message-Sender-Via: cloud706.unlimitedwebhosting.co.uk: authenticated_id: davidjoh/from_h X-Authenticated-Sender: cloud706.unlimitedwebhosting.co.uk: beagleboard@davidjohnsummers.uk X-Source: X-Source-Args: X-Source-Dir: X-Barracuda-Connect: no-dns-yet.unlimited.uk.net[149.255.62.7] X-Barracuda-Start-Time: 1550952980 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://149.255.60.72:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at thundercloud.uk X-Barracuda-Scan-Msg-Size: 3873 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.67780 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On 22/02/2019 19:21, Vasily Khoruzhick wrote: > On Fri, Feb 22, 2019 at 11:14 AM David Summers > wrote: >> Hi Vasily, >> >> Just catching up with this series - good that you are doing it. We need >> it for users on ArchLinux ARM! >> >> On question though, what is "firmware-postfix" used for? I see in the >> documentation, that it points to the board name. But can't see where >> else it is used. > See h5_serdev_probe() in drivers/bluetooth/hci_h5.c. Basically it > specifies what firmware config to use. > I agree with Rob that we should probably use firmware-name here instead. Ah OK followed it. its sets h5->id than in h5_btrtl_setup (in hci_h5) calls up btrtl_initialise (in btrtl.c) and that gives the file to load. Guess now need to trace what firmware files are available. Oh yes - see why you called it postfix, as that is the name given in btrl_initialise. I can't comment on what name is best, but I can see the sense of keeping the device tree hook the same as used as in btrtl_initialise. >> Is there a need to have the board name? > As far as I understand firmware config depends on board, so I think > it's a good idea to use board name here. > >> Anyway good work. > Thanks! > >> David. >> >> On 18/02/2019 22:28, Vasily Khoruzhick wrote: >>> On Mon, Feb 18, 2019 at 2:08 PM Stefan Wahren wrote: >>>> Hi Vasily, >>> Hi Stefan, >>> >>>>> Vasily Khoruzhick hat am 18. Februar 2019 um 22:24 geschrieben: >>>>> >>>>> >>>>> On Mon, Feb 18, 2019 at 1:10 PM Rob Herring wrote: >>>>>> On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhick wrote: >>>>>>> Add binding document for bluetooth part of RTL8723BS/RTL8723CS >>>>>>> >>>>>>> Signed-off-by: Vasily Khoruzhick >>>>>>> --- >>>>>>> .../bindings/net/rtl8723bs-bluetooth.txt | 35 +++++++++++++++++++ >>>>>>> 1 file changed, 35 insertions(+) >>>>>>> create mode 100644 Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt >>>>>>> >>>>>>> diff --git a/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt b/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt >>>>>>> new file mode 100644 >>>>>>> index 000000000000..8357f242ae4c >>>>>>> --- /dev/null >>>>>>> +++ b/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt >>>>>>> @@ -0,0 +1,35 @@ >>>>>>> +RTL8723BS/RTL8723CS Bluetooth >>>>>>> +--------------------- >>>>>>> + >>>>>>> +RTL8723CS/RTL8723CS is WiFi + BT chip. WiFi part is connected over SDIO, while >>>>>>> +BT is connected over serial. It speaks H5 protocol with few extra commands >>>>>>> +to upload firmware and change module speed. >>>>>>> + >>>>>>> +Required properties: >>>>>>> + >>>>>>> + - compatible: should be one of the following: >>>>>>> + * "realtek,rtl8723bs-bt" >>>>>>> + * "realtek,rtl8723cs-bt" >>>>>>> +Optional properties: >>>>>>> + >>>>>>> + - device-wake-gpios: GPIO specifier, used to wakeup the BT module (active high) >>>>>>> + - enable-gpios: GPIO specifier, used to enable the BT module (active high) >>>>>>> + - host-wake-gpios: GPIO specifier, used to wakeup the host processor (active high) >>>>>>> + - firmware-postfix: firmware postfix to be used for firmware config >>>> sorry, i didn't noticed your great series before. David and i working at the same stuff but for the Asus Tinker Board. >>>> >>>> I created a similiar yet untested patch version for hci_h5 [1]. Maybe it's useful. >>> Looks good to me, but you may need to add firmware-postfix. >>> >>>> Just a comment about the binding. It's really necessary to add the reset-gpio? Can't we use the enable-gpio with inverse polarity for this? >>> Yes, we can use enable-gpio instead of reset-gpio on pine64 and pinebook. >>> >>>> Stefan >>