Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH 1/5] Bluetooth: Expose supported LE states via debugfs
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20190220101428.3086-1-andrzej.kaczmarek@codecoup.pl>
Date:   Tue, 26 Feb 2019 10:06:06 +0100
Cc:     linux-bluetooth@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <176433CA-5971-48CF-B550-4516D92DD014@holtmann.org>
References: <20190220101428.3086-1-andrzej.kaczmarek@codecoup.pl>
To:     Andrzej Kaczmarek <andrzej.kaczmarek@codecoup.pl>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Andrzej,

> It may be useful for debugging purposes to quickly retrieve supported LE
> stated bit mask for controller.
> 
> Signed-off-by: Andrzej Kaczmarek <andrzej.kaczmarek@codecoup.pl>
> ---
> net/bluetooth/hci_debugfs.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
> 
> diff --git a/net/bluetooth/hci_debugfs.c b/net/bluetooth/hci_debugfs.c
> index 51f5b1efc3a5..c0b11ebacf7d 100644
> --- a/net/bluetooth/hci_debugfs.c
> +++ b/net/bluetooth/hci_debugfs.c
> @@ -679,6 +679,29 @@ static const struct file_operations force_static_address_fops = {
> 	.llseek		= default_llseek,
> };
> 
> +static int le_states_show(struct seq_file *f, void *ptr)
> +{
> +	struct hci_dev *hdev = f->private;
> +
> +	hci_dev_lock(hdev);
> +	seq_printf(f, "LE: %8ph\n", hdev->le_states);
> +	hci_dev_unlock(hdev);
> +
> +	return 0;
> +}
> +
> +static int le_states_open(struct inode *inode, struct file *file)
> +{
> +	return single_open(file, le_states_show, inode->i_private);
> +}
> +
> +static const struct file_operations le_states_fops = {
> +	.open		= le_states_open,
> +	.read		= seq_read,
> +	.llseek		= seq_lseek,
> +	.release	= single_release,
> +};
> +
> static int white_list_show(struct seq_file *f, void *ptr)
> {
> 	struct hci_dev *hdev = f->private;
> @@ -956,6 +979,8 @@ void hci_debugfs_create_le(struct hci_dev *hdev)
> 			    &random_address_fops);
> 	debugfs_create_file("static_address", 0444, hdev->debugfs, hdev,
> 			    &static_address_fops);
> +	debugfs_create_file("le_states", 0444, hdev->debugfs, hdev,
> +			    &le_states_fops);

we have not used le_ prefixed files yet and so maybe better use supported_states here.

Regards

Marcel