Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH BlueZ] test: Enable test-mesh to send raw vendor commands
From:   Johan Hedberg <johan.hedberg@gmail.com>
In-Reply-To: <20190322034927.6247-1-inga.stotland@intel.com>
Date:   Fri, 22 Mar 2019 09:01:18 +0200
Cc:     linux-bluetooth@vger.kernel.org,
        "Gix, Brian" <brian.gix@intel.com>,
        Luiz Von Dentz <luiz.dentz@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <82D05BF3-3E54-4BB1-B22B-72F1C94051A5@gmail.com>
References: <20190322034927.6247-1-inga.stotland@intel.com>
To:     Inga Stotland <inga.stotland@intel.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Inga,

On 22 Mar 2019, at 5.49, Inga Stotland <inga.stotland@intel.com> wrote:
> +#       5 - on/off model client menu
> +#       6 - send raw message
> +#       7 - exit

Please don=E2=80=99t use numeric identifiers for commands in interactive =
tools. Use intuitive, human readable strings like we do in the other =
interactive tools in the tree. Numbers might be convenient for =
computers, but they=E2=80=99re not particularly human friendly :)

Johan