From:   "Gix, Brian" <brian.gix@intel.com>
To:     Johan Hedberg <johan.hedberg@gmail.com>
CC:     "Stotland, Inga" <inga.stotland@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "Luiz Von Dentz" <luiz.dentz@gmail.com>
Subject: Re: [PATCH BlueZ] test: Enable test-mesh to send raw vendor commands
Thread-Topic: [PATCH BlueZ] test: Enable test-mesh to send raw vendor
 commands
Thread-Index: AQHU4GJHtLMbq64yGUW+wrDcBbusaqYXrqwA////1qk=
Date:   Fri, 22 Mar 2019 14:00:42 +0000
Message-ID: <2815DD46-4BB1-46DC-881D-1C30200DAED9@intel.com>
References: <20190322034927.6247-1-inga.stotland@intel.com>,<82D05BF3-3E54-4BB1-B22B-72F1C94051A5@gmail.com>
In-Reply-To: <82D05BF3-3E54-4BB1-B22B-72F1C94051A5@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Johan,

> On Mar 22, 2019, at 12:02 AM, Johan Hedberg <johan.hedberg@gmail.com> wrote:
> 
> Hi Inga,
> 
>> On 22 Mar 2019, at 5.49, Inga Stotland <inga.stotland@intel.com> wrote:
>> +#       5 - on/off model client menu
>> +#       6 - send raw message
>> +#       7 - exit
> 
> Please don?t use numeric identifiers for commands in interactive tools. Use intuitive, human readable strings like we do in the other interactive tools in the tree. Numbers might be convenient for computers, but they?re not particularly human friendly :)

We do plan on making better tools, but this is mostly intended as a tester script to quickly allow us to test stuff, particularly the d-bus APIs, and demonstrate the way the methods are called from python.


> 
> Johan