Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH BlueZ] test: Enable test-mesh to send raw vendor commands
From:   Johan Hedberg <johan.hedberg@gmail.com>
In-Reply-To: <2815DD46-4BB1-46DC-881D-1C30200DAED9@intel.com>
Date:   Sat, 23 Mar 2019 12:08:49 +0200
Cc:     "Stotland, Inga" <inga.stotland@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Luiz Von Dentz <luiz.dentz@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E232C390-8571-40A5-9E72-2499E9973959@gmail.com>
References: <20190322034927.6247-1-inga.stotland@intel.com>
 <82D05BF3-3E54-4BB1-B22B-72F1C94051A5@gmail.com>
 <2815DD46-4BB1-46DC-881D-1C30200DAED9@intel.com>
To:     "Gix, Brian" <brian.gix@intel.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Brian

On 22 Mar 2019, at 16.00, Gix, Brian <brian.gix@intel.com> wrote:
>>> On 22 Mar 2019, at 5.49, Inga Stotland <inga.stotland@intel.com> =
wrote:
>>> +#       5 - on/off model client menu
>>> +#       6 - send raw message
>>> +#       7 - exit
>>=20
>> Please don=E2=80=99t use numeric identifiers for commands in =
interactive tools. Use intuitive, human readable strings like we do in =
the other interactive tools in the tree. Numbers might be convenient for =
computers, but they=E2=80=99re not particularly human friendly :)
>=20
> We do plan on making better tools, but this is mostly intended as a =
tester script to quickly allow us to test stuff, particularly the d-bus =
APIs, and demonstrate the way the methods are called from python.

Understood, however what I proposed

 - Doesn=E2=80=99t take really any extra effort
 - Is friendlier to the user
 - Is friendlier to the reader of the code (no need to do number lookups =
to understand the purpose of a branch)
 - Is consistent with the rest of the code base

=E2=80=A6 so I don=E2=80=99t understand why you wouldn=E2=80=99t want =
that, even if it=E2=80=99s a quick test tool :)

I suppose the long-term idea is to provide the same kind of interactive =
command-line interface as meshctl has provided for provisioner and =
configuration client role? In fact, would it make sense to keep using =
meshctl for that and hide the detail whether stuff is going via meshd or =
not?

Johan=