Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0803C282CE for ; Fri, 5 Apr 2019 21:05:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 519192186A for ; Fri, 5 Apr 2019 21:05:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HfizJm8P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726204AbfDEVF6 (ORCPT ); Fri, 5 Apr 2019 17:05:58 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:40847 "EHLO mail-ed1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725967AbfDEVF6 (ORCPT ); Fri, 5 Apr 2019 17:05:58 -0400 Received: by mail-ed1-f53.google.com with SMTP id h22so6671179edw.7; Fri, 05 Apr 2019 14:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vorx3N0hq0lxKYq8Qd+0cz//iTVOE8kJyu8slSyupE0=; b=HfizJm8PCvvhkFzMCwCNt7Lod8Ej7daJqEvKH87aGIem8SFNoRGMHeEU4hFADaEcoV uHeTE+clgGgAu4gGnOmsqnzDkB2+kQ7pYeaxKSKTYmf90tbBfZk+HU2QwXfs74Brv7h2 ahUvYX/8FZ9YCLOaHic7Z/BsU9OojKJGj73UY9G8ZwquK8/CkVjFMLq6jHz2jZJROdW9 QV/zLkq3pGBNZeDu2DPTw+3tq6IaiX1vPlXBgjd3WyrUp5eVVTCspwmPMoL9Cq1OyOiq SsOW5DDSGCvvZWQ6I8Aqp2qVXnVWRQLHycoZFy18t8hEjW9m6vhyp59wQQI23OvxosC2 jAyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=vorx3N0hq0lxKYq8Qd+0cz//iTVOE8kJyu8slSyupE0=; b=DvZdeFgb/OQ3NvnW6/Y62fmjWc/ndnT476/DDTM9at5Ycxck7GFAklDfafUXFieBi3 B2UuAoQFh58ZOXlUZcfZC+0aVTL3/j2WdWe+fQhiyi8HsnsZdFi7vSdpGF9R8h0UByjp 5LY7RsJ3+gLHYN9j4AzDDmewb/umLkw/krjKY8bgYpc5kno6bUmB1Dm7745BBopaPxOa tnSCNuCfQCyQQhDWvAlsMKffJT/O2xJMePRi5JmyvhOelEIFf5xM3pCeNyefRXJ+oAmt twuNjiZIcb5goHdex/OVjUEQZjG7asQ6YLr2G2bYPgp55sJb/z1iVFIAtdwgC73U4GK9 joQA== X-Gm-Message-State: APjAAAVs8K+v0VNELFvRK8x5xOysGJR+VkJxGEmiTIbDNnZGR3BRhM3q TuXW5+r0bMvBw78U42SMXfrM6QUiVfA= X-Google-Smtp-Source: APXvYqyirw92+1/X1pFhnEYEYiaqk08QZbJs8FvDEm7hQRgIPO38UObsh/bPV9l22cOUl8/w98evAg== X-Received: by 2002:a17:906:5e0d:: with SMTP id n13mr8407994eju.37.1554498355432; Fri, 05 Apr 2019 14:05:55 -0700 (PDT) Received: from [192.168.0.61] (xd520f252.cust.hiper.dk. [213.32.242.82]) by smtp.gmail.com with ESMTPSA id c16sm4703468edc.75.2019.04.05.14.05.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 14:05:54 -0700 (PDT) Subject: Re: [PATCH] Bluetooth: hci_event: potential out of bounds parsing ADV events To: Dan Carpenter , Cong Wang Cc: Marcel Holtmann , Jaganath Kanakkassery , Johan Hedberg , linux-bluetooth , kernel-janitors@vger.kernel.org References: <20190330072511.GA5502@kadam> <20190402063313.GA32613@kadam> <20190402195537.GF32613@kadam> <20190404080627.GG32590@kadam> <20190405204838.GR32590@kadam> From: Tomas Bortoli Openpgp: preference=signencrypt Autocrypt: addr=tomasbortoli@gmail.com; prefer-encrypt=mutual; keydata= mQINBFpCTZMBEADNZ1+Ibh0Z4pgGRcd1aOUMbe/YfHktmajjcoTnKmZZunjoUVAl8waeLITd BC2c8i1wHzHcnthrmb1izs5XlG6PZnl8n5tjysSNbwggzS1NcEK1qgn5VjNlHQ5aRMUwCC51 kicBiNmlQk2UuzzWwdheRGnaf+O1MNhC0GBeEDKQAL5obOU92pzflv6wWNACr+lHxdnpyies mOnRMjH16NjuTkrGbEmJe+MKp0qbjvR3R/dmFC1wczniRMQmV5w3MZ/N9wRappE+Atc1fOM+ wP7AWNuPvrKg4bN5uqKZLDFH7OFpxvjgVdWM40n0cQfqElWY9as+228Sltdd1XyHtUWRF2VW O1l5L0kX0+7+B5k/fpLhXqD3Z7DK7wRXpXmY59pofk7aFdcN97ZK+r6R7mqrwX4W9IpsPhkT kUyg3/Dx/khBZlJKFoUP325/hoH684bSiPEBroel9alB7gTq2ueoFwy6R3q5CMUw3D+CZWHA 3xllu46TRQ/Vt2g0cIHQNPoye2OWYFJ6kSEvaLpymjNDJ9ph2EuHegonDfOaYSq34ic2BcdB JkCgXRLP5K7KtRNJqqR+DM8xByeGmQv9yp6S97el+SiM9R53RhHawJZGz0EPl+2Q6+5mgh3u wXOlkmGrrSrlB8lc567l34ECl6NFtUPIL7H5vppIXAFl7JZUdQARAQABtB50b21hcyA8dG9t YXNib3J0b2xpQGdtYWlsLmNvbT6JAlQEEwEIAD4WIQSKOZIcNF9TdAG6W8ARUi5Y8x1zLgUC WkJNkwIbIwUJCWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRARUi5Y8x1zLvCXD/9h iaZWJ6bC6jHHPGDMknFdbpNnB5w1hBivu9KwAm4LyEI+taWhmUg5WUNO1CmDa2WGSUSTk9lo uq7gH8Y7zwGrYOEDVuldjRjPFR/1yW2JdAmbwzcYkVU0ZUhyo2XzgFjsnv3vJGHk/afEopce U6mOc2BsGDpo2izVTE/HVaiLE9jyKQF6Riy04QBRAvxbDvx1rl26GIxVI6coBFf4SZhZOnc0 dzsip0/xaSRRIMG0d75weezIG49qK3IHyw2Fw5pEFY8tP0JJVxtrq2MZw+n4WmW9BVD/oCd/ b0JZ4volQbOFmdLzcAi2w7DMcKVkW11I1fiRZ/vLMvA4b79r6mn3WJ8aMIaodG6CQzmDNcsF br+XVp8rc58m9q69BTzDH0xTStxXiwozyISAe2VGbGUbK9ngU/H1RX0Y01uQ9Dz0KfyjA0/Z QOBa4N1n1qoKFzoxTpu0Vyumkc5EnTk8NdWszt7UAtNSaIZcBuWHR7Kp0DqRHwom0kgTiNXJ 8uNgvvFTkPd2Pdz1BqbpN1Fj856xPuKIiqs5qXI2yh3GhntFDbTOwOU3rr3x5NEv3wFVojdi HcLM+KVf29YkRHzuEQT5YT9h6qTk2aFRqq3HSXrP56hQ3whR7bQtziJspkuj+ekeTxcZ5lr4 9FJI03hQJ4HbHn6x/Xw0+WjIOo4jBeUEI7kCDQRaQk2TARAA4JCPcQcISPAKKC1n9VQxgdH3 oMqxhJ+gh/0Yb394ZYWLf7qOVQf/MgALPQIIFpcwYrw7gK4hsN7kj1vwPFy9JIqZtkgbmJHm aCj1LkZuf8tp5uvqzMZGcgm28IO6qDhPggeUE3hfA/y5++Vt0Jsmrz5zVPY0bOrLh1bItLnF U3uoaHWkAi/rhM6WwlsxemefzKulXoR9PIGVZ/QGjBGsTkNbTpiz2KsN+Ff/ZgjBJzGQNgha kc6a+eXyGC0YE8fRoTQekTi/GqGY7gfRKkgZDPi0Ul0sPZQJo07Dpw0nh5l6sOO+1yXygcoA V7I4bUeANZ9QJzbzZALgtxbT6jTKC0HUbF9iFb0yEkffkQuhhIqud7RkITe25hZePN8Y6Px0 yF4lEVW/Ti91jMSb4mpZiAaIFcdDV0CAtIYHAcK1ZRVz//+72o4gMZlRxowxduMyRs3L5rE0 ZkFQ6aPan+NBtEk1v3RPqnsQwJsonmiEgfbvybyBpP5MzRZnoAxfQ9vyyXoI5ofbl/+l9wv8 mosKNWIjiQsX3KiyaqygtD/yed5diie5nA7eT6IjL92WfgSelhBCL4jV0fL4w8hah2Azu0Jg 1ZtjjgoDObcAKQ5dLJA0IDsgH/X/G+ZMvkPpPIVaS5QWkiv66hixdKte/4iUrN+4waxJLCit 1KGC2xPJ2UUAEQEAAYkCPAQYAQgAJhYhBIo5khw0X1N0AbpbwBFSLljzHXMuBQJaQk2TAhsM BQkJZgGAAAoJEBFSLljzHXMuOb0P/1EnY4Y6LfQ6bmhJQ6epA3fB70hRWCQsuPYLAgPKRoXy kmWH4ljqQDbA55TtIpnod/woR0IDnZcD7E9cyGzM2rHvSLXTkHhgIWacZHZopAUzq4j0lhiJ Wu57freQPU4rzMVGZXBktUsDMsJwp/3Tl2Kjqylh90qIOlB9laUusLIbl4w5J3EscIJzWvdL y1lJLtBmus/t75wN/aIB8l9YBKGuy0L4SAmjhN52pCgP/S+ANEKvdghQco51a4jD2Pv2uYH7 nUU/Y70AmqOHjPR+qZ0hAUw6B+UtWQ+Fl587Qqi2XPUzdA8G2EjGFFPRlnhf2H/gOyAfeVYL NDwDgm9Yzp7Rx0O1QOnQsXTHqk7K38AdSdM2li/I/zegeblInnLi08Gq6mT6RkD6wV9HE5U3 EIU0rDPyJo54MW39wGjfC2+PM5I0xebbxtnuTewRchVVfm7UWgLAy11pV3xM4wMSJOuqVMOz jYpWKYxDTpvsZ0ginUUY993Gb8k/CxjABEMUGVHhQPZ0OzjHIKS6cTzN6ue8bB+CGOLCaQp1 C0NRT5Tn9zpLxtf5nBExFd/zVENY5vAV2ZbKQdemO54O7j6B9DSgVRrm83GCZxbL4d+qTYBF 3tSCWw/6SG1F3q9gR9QrSC2YRjCmhijUVEh6FhZwB58TNZ1sEEttrps8TDa5tUd9 Message-ID: <5344bfc8-ba02-c17f-c4cd-0418d48e6fdd@gmail.com> Date: Fri, 5 Apr 2019 23:05:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190405204838.GR32590@kadam> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org I disagree, they differ for me. with unlikely: f86cf90c9c1ef14063796f4d07ce64bf6952b536e9728d21ba86d3be2e7472d7 net/bluetooth/hci_event.o without: 6c75194b981294cb933900100448ec335065a35ff9120333558d09aa3dd8b2da net/bluetooth/hci_event.o On 4/5/19 10:48 PM, Dan Carpenter wrote: > > I'm don't have a lot of time for these discussions. The object code is > exactly the same regardless of whether you add the annotations or not. > > 32c307d27583a624baa3a24eec00402e net/bluetooth/hci_event.o.no_annotation > 32c307d27583a624baa3a24eec00402e net/bluetooth/hci_event.o.w_annotation > > regards, > dan carpenter >