Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: Re: [PATCH] Bluetooth: hci_bcm: Fix empty regulator supplies for
 Intel Macs
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20190401034312.27475-1-wens@kernel.org>
Date:   Tue, 23 Apr 2019 19:28:53 +0200
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        Chen-Yu Tsai <wens@csie.org>, linux-bluetooth@vger.kernel.org,
        linux-kernel@vger.kernel.org, Imre Kaloz <kaloz@dune.hu>,
        stable@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <1989EF87-D91F-4672-8DC4-C5A67F5C1331@holtmann.org>
References: <20190401034312.27475-1-wens@kernel.org>
To:     Chen-Yu Tsai <wens@kernel.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Chen-Yu,

> The code path for Macs goes through bcm_apple_get_resources(), which
> skips over the code that sets up the regulator supplies. As a result,
> the call to regulator_bulk_enable() / regulator_bulk_disable() results
> in a NULL pointer dereference.
> 
> This was reported on the kernel.org Bugzilla, bug 202963.
> 
> Unbreak Broadcom Bluetooth support on Intel Macs by checking if the
> supplies were set up before enabling or disabling them.
> 
> The same does not need to be done for the clocks, as the common clock
> framework API checks for NULL pointers.
> 
> Fixes: 75d11676dccb ("Bluetooth: hci_bcm: Add support for regulator supplies")
> Cc: <stable@vger.kernel.org> # 5.0.x
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> 
> I do not own a Mac, so this needs to be tested by someone else.
> 
> ---
> drivers/bluetooth/hci_bcm.c | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel