Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: Re: [PATCH] Bluetooth: btintel: improvement: mask vendor events from
 controller
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <1556097059-31577-1-git-send-email-amit.k.bag@intel.com>
Date:   Wed, 24 Apr 2019 12:26:50 +0200
Cc:     linux-bluetooth@vger.kernel.org, ravishankar.srivatsa@intel.com,
        chethan.tumkur.narayan@intel.com
Content-Transfer-Encoding: 8BIT
Message-Id: <1F2562C9-0C63-410E-957C-1C79CA86A02E@holtmann.org>
References: <1556097059-31577-1-git-send-email-amit.k.bag@intel.com>
To:     Amit K Bag <amit.k.bag@intel.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Amit,

> This patch mask unnecessary event notifications from controller to host
> 
> Signed-off-by: Amit K Bag <amit.k.bag@intel.com>
> ---
> drivers/bluetooth/btintel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index 5270d5513201..7e5cdd37cc1f 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -313,7 +313,7 @@ EXPORT_SYMBOL_GPL(btintel_load_ddc_config);
> 
> int btintel_set_event_mask(struct hci_dev *hdev, bool debug)
> {
> -	u8 mask[8] = { 0x87, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
> +	u8 mask[8] = { 0x01, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
> 	struct sk_buff *skb;
> 	int err;

so I enabled actually many more events to ensure we get proper output in btmon in case something happens. So you need to be more specific why we want to not enable these events for our hardware.

Regards

Marcel