Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190430103001.30661-1-michal.lowas-rzechonek@silvair.com>
In-Reply-To: <20190430103001.30661-1-michal.lowas-rzechonek@silvair.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 30 Apr 2019 15:41:51 +0300
Message-ID: <CABBYNZK8RJ4+oiTz2jFKoA7GyRgCBLMjm3FVtQ_=-twEuTLvNg@mail.gmail.com>
Subject: Re: [PATCH v2] a2dp: Fixed warn_unused_result warning
To:     =?UTF-8?Q?Micha=C5=82_Lowas=2DRzechonek?= 
        <michal.lowas-rzechonek@silvair.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Micha=C5=82,

On Tue, Apr 30, 2019 at 1:31 PM Micha=C5=82 Lowas-Rzechonek
<michal.lowas-rzechonek@silvair.com> wrote:
>
> This used to break builds when using maintainer mode via
> ./bootstrap-configure:
>
> profiles/audio/a2dp.c:1775:2: error: ignoring return value of
>     =E2=80=98asprintf=E2=80=99, declared with attribute warn_unused_resul=
t
>     [-Werror=3Dunused-result]
>   asprintf(&sep->path, "%s/sep%d",
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ---
>  profiles/audio/a2dp.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
> index 8f141739c..5f5ad508d 100644
> --- a/profiles/audio/a2dp.c
> +++ b/profiles/audio/a2dp.c
> @@ -1772,8 +1772,15 @@ static void register_remote_sep(void *data, void *=
user_data)
>         if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL))
>                 goto done;
>
> -       asprintf(&sep->path, "%s/sep%d", device_get_path(chan->device),
> -                                                       avdtp_get_seid(rs=
ep));
> +       if (asprintf(&sep->path, "%s/sep%d",
> +                               device_get_path(chan->device),
> +                               avdtp_get_seid(rsep)) < 0) {
> +               error("Could not allocate path for remote sep %s/sep%d",
> +                               device_get_path(chan->device),
> +                               avdtp_get_seid(rsep));
> +               sep->path =3D NULL;
> +               goto done;
> +       }
>
>         if (g_dbus_register_interface(btd_get_dbus_connection(),
>                                 sep->path, MEDIA_ENDPOINT_INTERFACE,
> --
> 2.19.1

Applied, thanks.

--=20
Luiz Augusto von Dentz