Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: Re: [PATCH] v7 Add support for LE ping feature
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <6AFF54953E047B42BC60A96154D42C5CD16F45@BGSMSX101.gar.corp.intel.com>
Date:   Mon, 6 May 2019 11:00:26 +0200
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <09C2920E-805F-4DB2-8C2D-C338650604AD@holtmann.org>
References: <1556597465-21783-1-git-send-email-spoorthix.k@intel.com>
 <E76A1D30-87DF-4A83-B9AD-C7DCC193EB6C@holtmann.org>
 <6AFF54953E047B42BC60A96154D42C5CD16F45@BGSMSX101.gar.corp.intel.com>
To:     "K, SpoorthiX" <spoorthix.k@intel.com>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Spoorthi,

> 	Thanks for your valuable comments.
> 	I have removed the extra lines wherever mentioned in my latest patch sent few minutes back.
> 	But I clearly did not understand the comment 
> 	---> On hci_conn creation the hcon->auth_payload_time needs to be set to DEFAULT_AUTH_PAYLOAD_TIMEOUT as well.
> 	Could you please explain why this needs to be set after connection as it is sent as a command parameter  "hdev->auth_payload_timeout" is nothing but “DEFAULT_AUTH_PAYLOAD_TIMEOUT"

when you initialize the hci_conn structure you have to fill it with the correct default values. The auth payload is not 0x0000 in this case since the controller will already have one that it uses as default. The specification clearly states that Authenticated_Payload_Timeout Default = 0x0BB8 (30 s). This means that one encryption has been activated the LE Ping procedure is active with the default 30s no matter if you send the HCI Write Authenticated Payload Timeout command or not.

Regards

Marcel