Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH BlueZ v2] mesh: Use node uuids as storage directory names
To:     "Gix, Brian" <brian.gix@intel.com>,
        "michal.lowas-rzechonek@silvair.com" 
        <michal.lowas-rzechonek@silvair.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Cc:     "Stotland, Inga" <inga.stotland@intel.com>
References: <20190507071340.20675-1-michal.lowas-rzechonek@silvair.com>
 <1557261666.31289.11.camel@intel.com>
From:   Denis Kenzior <denkenz@gmail.com>
Message-ID: <18e096c6-3b22-0096-5cb2-bef7264dbefe@gmail.com>
Date:   Tue, 7 May 2019 15:55:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <1557261666.31289.11.camel@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Brian,

On 05/07/2019 03:41 PM, Gix, Brian wrote:

<snip>

>> +		if (asprintf(&cfg, "%s/%s/node.json", dir_name,
>> +						entry->d_name) < 0)
>> +			continue;
> 
> With ELL, we do not use asprintf.  Every dynamic allocation must map back to l_malloc, which performs an
> abort() if a memory allocation fails.  So this should be re-coded as a malloc of the desired size, and then use
> snprintf, using the malloc'd length as N.
> 

...or use l_strdup_printf.  Which is actually asprintf underneath... ;)

Regards,
-Denis