Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 8 May 2019 06:39:01 +0200
From:   "michal.lowas-rzechonek@silvair.com" 
        <michal.lowas-rzechonek@silvair.com>
To:     Denis Kenzior <denkenz@gmail.com>
Cc:     "Gix, Brian" <brian.gix@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "Stotland, Inga" <inga.stotland@intel.com>
Subject: Re: [PATCH BlueZ v2] mesh: Use node uuids as storage directory names
Message-ID: <20190508043901.bcueazjay3nm6cya@kynes>
Mail-Followup-To: Denis Kenzior <denkenz@gmail.com>,
        "Gix, Brian" <brian.gix@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "Stotland, Inga" <inga.stotland@intel.com>
References: <20190507071340.20675-1-michal.lowas-rzechonek@silvair.com>
 <1557261666.31289.11.camel@intel.com>
 <18e096c6-3b22-0096-5cb2-bef7264dbefe@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <18e096c6-3b22-0096-5cb2-bef7264dbefe@gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Denis, Brian,

On 05/07, Denis Kenzior wrote:
> > > +		if (asprintf(&cfg, "%s/%s/node.json", dir_name,
> > > +						entry->d_name) < 0)
> > > +			continue;
> > 
> > With ELL, we do not use asprintf.  Every dynamic allocation must map
> > back to l_malloc, which performs an abort() if a memory allocation
> > fails.  So this should be re-coded as a malloc of the desired size,
> > and then use snprintf, using the malloc'd length as N.
> 
> ...or use l_strdup_printf.  Which is actually asprintf underneath...
> ;)
Will do, thanks for the tip!

Incidentally, are you aware why 'main' bluez aims to drop glib?

cheers
-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND