Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "=?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek" 
        <michal.lowas-rzechonek@silvair.com>
Date:   Thu, 9 May 2019 21:11:35 +0200
To:     Brian Gix <brian.gix@intel.com>
Cc:     linux-bluetooth@vger.kernel.org, inga.stotland@intel.com
Subject: Re: [PATCH BlueZ v5 2/2] mesh: Add key storage
Message-ID: <20190509191135.y6rbo5ziv6hrxxah@kynes>
Mail-Followup-To: Brian Gix <brian.gix@intel.com>,
        linux-bluetooth@vger.kernel.org, inga.stotland@intel.com
References: <20190509175739.16891-1-brian.gix@intel.com>
 <20190509175739.16891-3-brian.gix@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190509175739.16891-3-brian.gix@intel.com>
User-Agent: NeoMutt/20180716
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi again,

On 05/09, Brian Gix wrote:
> +	fd = open(key_file, O_WRONLY | O_CREAT | O_TRUNC);
> +	if (fd > 0) {
Hm. I might be mistaken, since I'm not that much familiar with systemd
internals, but 'back in the day' daemons were expected to close their
stdin, leaving descriptor #0 free for reuse.

regards
-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND