Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Fix cups backend location
To:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Cc:     Bastien Nocera <hadess@hadess.net>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>
References: <20190412140803.28622-1-ludwig.nussel@suse.de>
 <CABBYNZ+4Mgp0h2YusoEVK64a-uTXdarANc+Tm-KKpjR1=9h2cg@mail.gmail.com>
 <6339c67c82a7e425a3c3cee415626cf32e080144.camel@hadess.net>
From:   Ludwig Nussel <ludwig.nussel@suse.de>
Organization: SUSE Linux GmbH
Message-ID: <afc28fae-b1ef-24f6-4878-33205bccb947@suse.de>
Date:   Thu, 23 May 2019 14:07:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <6339c67c82a7e425a3c3cee415626cf32e080144.camel@hadess.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Bastien Nocera schrieb:
> On Mon, 2019-04-15 at 10:52 +0300, Luiz Augusto von Dentz wrote:
>> Hi Bastien,
>>
>> On Fri, Apr 12, 2019 at 5:11 PM Ludwig Nussel <ludwig.nussel@suse.de>
>> wrote:
>>> ---
>>>   Makefile.tools | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Makefile.tools b/Makefile.tools
>>> index 7d5361bcd..9f8a0b87b 100644
>>> --- a/Makefile.tools
>>> +++ b/Makefile.tools
>>> @@ -436,7 +436,10 @@ endif
>>>   endif
>>>
>>>   if CUPS
>>> -cupsdir = $(libdir)/cups/backend
>>> +# need to use upstream location here which is
>>> $exec_prefix/lib/cups/backend, see
>>> +#
>>> https://github.com/apple/cups/blob/master/config-scripts/cups-directories.m4
>>> +# https://github.com/apple/cups/blob/master/backend/Makefile
>>> +cupsdir = $(exec_prefix)/lib/cups/backend
>>>
>>>   cups_PROGRAMS = profiles/cups/bluetooth
>>
>> Any feedback on these changes?
> 
> The Fedora package has been doing that manually for 11 years, so, yes
> that looks correct.
> 
> It should probably be using the output of
> "cups-config --serverbin" instead, but given how hard that is with
> autotools, this is probably fine. I'd mention it in the commend instead
> of linking at the code though.

The output of cups-config doesn't give a hint about exec_prefix vs
libdir though. Since reading through those files I linked was what I
did to understand what the correct value was, I thought mentioning
them would help the text person.
So what comment should I put to get this patch accepted? Looks like none
like before was ok for years after all :-)

I'm not really up to spending a day crafting M4 macros for the perfect
cups special arrangement.

cu
Ludwig

-- 
  (o_   Ludwig Nussel
  //\
  V_/_  http://www.suse.com/
SUSE Linux GmbH, GF: Felix Imendörffer, Mary Higgins, Sri Rasiah,
HRB 21284 (AG Nürnberg)