Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <3d3682d1b30d09011d69050bc24aeda26bb2c066.camel@hadess.net>
Subject: Re: [PATCH] Fix cups backend location
From:   Bastien Nocera <hadess@hadess.net>
To:     Ludwig Nussel <ludwig.nussel@suse.de>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Cc:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 23 May 2019 14:11:34 +0200
In-Reply-To: <afc28fae-b1ef-24f6-4878-33205bccb947@suse.de>
References: <20190412140803.28622-1-ludwig.nussel@suse.de>
         <CABBYNZ+4Mgp0h2YusoEVK64a-uTXdarANc+Tm-KKpjR1=9h2cg@mail.gmail.com>
         <6339c67c82a7e425a3c3cee415626cf32e080144.camel@hadess.net>
         <afc28fae-b1ef-24f6-4878-33205bccb947@suse.de>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.2 (3.32.2-1.fc30) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On Thu, 2019-05-23 at 14:07 +0200, Ludwig Nussel wrote:
> Bastien Nocera schrieb:
> > On Mon, 2019-04-15 at 10:52 +0300, Luiz Augusto von Dentz wrote:
> > > Hi Bastien,
> > > 
> > > On Fri, Apr 12, 2019 at 5:11 PM Ludwig Nussel <
> > > ludwig.nussel@suse.de>
> > > wrote:
> > > > ---
> > > >   Makefile.tools | 5 ++++-
> > > >   1 file changed, 4 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/Makefile.tools b/Makefile.tools
> > > > index 7d5361bcd..9f8a0b87b 100644
> > > > --- a/Makefile.tools
> > > > +++ b/Makefile.tools
> > > > @@ -436,7 +436,10 @@ endif
> > > >   endif
> > > > 
> > > >   if CUPS
> > > > -cupsdir = $(libdir)/cups/backend
> > > > +# need to use upstream location here which is
> > > > $exec_prefix/lib/cups/backend, see
> > > > +#
> > > > https://github.com/apple/cups/blob/master/config-scripts/cups-directories.m4
> > > > +# https://github.com/apple/cups/blob/master/backend/Makefile
> > > > +cupsdir = $(exec_prefix)/lib/cups/backend
> > > > 
> > > >   cups_PROGRAMS = profiles/cups/bluetooth
> > > 
> > > Any feedback on these changes?
> > 
> > The Fedora package has been doing that manually for 11 years, so,
> > yes
> > that looks correct.
> > 
> > It should probably be using the output of
> > "cups-config --serverbin" instead, but given how hard that is with
> > autotools, this is probably fine. I'd mention it in the commend
> > instead
> > of linking at the code though.
> 
> The output of cups-config doesn't give a hint about exec_prefix vs
> libdir though. Since reading through those files I linked was what I
> did to understand what the correct value was, I thought mentioning
> them would help the text person.

It needs to be mentioned in the commit message, not in the "code".

> So what comment should I put to get this patch accepted? Looks like
> none
> like before was ok for years after all :-)
> 
> I'm not really up to spending a day crafting M4 macros for the
> perfect
> cups special arrangement.

I already said it shouldn't be needed. Can you send a new patch with
the changes I requested?

Cheers