Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190521200313.11487-1-sbrown@ewol.com>
In-Reply-To: <20190521200313.11487-1-sbrown@ewol.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 24 May 2019 11:50:03 +0300
Message-ID: <CABBYNZLC=_XGWqpP94cN5ifg-jSbDyMekGWxOAg2Nis=yn81jA@mail.gmail.com>
Subject: Re: [PATCH v2] meshctl: Retry recvmsg if data is not ready
To:     Steve Brown <sbrown@ewol.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Steve,

On Tue, May 21, 2019 at 11:29 PM Steve Brown <sbrown@ewol.com> wrote:
>
> Commit d6eec1b67d6d ("meshctl: Switch from write to sendmsg for Acquire*")
> causes a regression by returning an error if recvmsg has no data available.
> Fix it by retrying until data is received.
> ---
> Changes in v2:
>   * Reword commit message
>  tools/mesh/gatt.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/mesh/gatt.c b/tools/mesh/gatt.c
> index 2269a20cf..0a942d4eb 100644
> --- a/tools/mesh/gatt.c
> +++ b/tools/mesh/gatt.c
> @@ -415,8 +415,11 @@ static bool sock_read(struct io *io, bool prov, void *user_data)
>         msg.msg_iovlen = 1;
>
>         while ((len = recvmsg(fd, &msg, MSG_DONTWAIT))) {
> -               if (len <= 0)
> +               if (len <= 0) {
> +                       if (errno == EAGAIN)
> +                               break;
>                         return false;
> +               }
>
>                 res = buf;
>                 len_sar = mesh_gatt_sar(&res, len);
> --
> 2.20.1

Applied, thanks.


-- 
Luiz Augusto von Dentz