Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <eed1d21883c605b92abe2b13cf658454444c9d39.camel@hadess.net>
Subject: Re: [RFC] Bluetooth: Check key sizes only when Secure Simple
 Pairing is enabled
From:   Bastien Nocera <hadess@hadess.net>
To:     Vasily Khoruzhick <anarsoul@gmail.com>,
        Marcel Holtmann <marcel@holtmann.org>
Cc:     "open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>
Date:   Tue, 04 Jun 2019 14:26:39 +0200
In-Reply-To: <CA+E=qVcW0aQ=D_0bvEbTL9VA5P_2iykbZpNr2xH8P-eHB3FSog@mail.gmail.com>
References: <20190522070540.48895-1-marcel@holtmann.org>
         <CA+E=qVcW0aQ=D_0bvEbTL9VA5P_2iykbZpNr2xH8P-eHB3FSog@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.2 (3.32.2-1.fc30) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On Thu, 2019-05-23 at 07:53 -0700, Vasily Khoruzhick wrote:
> On Wed, May 22, 2019 at 12:05 AM Marcel Holtmann <marcel@holtmann.org
> > wrote:
> > The encryption is only mandatory to be enforced when both sides are
> > using
> > Secure Simple Pairing and this means the key size check makes only
> > sense
> > in that case.
> > 
> > On legacy Bluetooth 2.0 and earlier devices like mice the
> > encryption was
> > optional and thus causing an issue if the key size check is not
> > bound to
> > using Secure Simple Pairing.
> > 
> > Fixes: d5bb334a8e17 ("Bluetooth: Align minimum encryption key size
> > for LE and BR/EDR connections")
> > Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> > Cc: stable@vger.kernel.org
> 
> Tested-by: Vasily Khoruzhick <anarsoul@gmail.com>

I've asked for this patch to be included in the current Fedora release:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org/thread/YE5OGFZRDJL2TFJK3RWU7AAWV3PFRMNB/

Hopefully, that means that it gets a bit more testing and gets merged upstream.

Cheers