Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190619074851.24039-1-jakub.witowski@silvair.com>
In-Reply-To: <20190619074851.24039-1-jakub.witowski@silvair.com>
From:   =?UTF-8?Q?Grzegorz_Ko=C5=82odziejczyk?= 
        <grzegorz.kolodziejczyk@codecoup.pl>
Date:   Wed, 19 Jun 2019 10:31:41 +0200
Message-ID: <CALevQMaSheh9nY88L53bV==vS=7V0DBY6wFtf+A=UyHDnjYS=g@mail.gmail.com>
Subject: Re: [PATCH v2] mesh: Return dbus error code on Leave() with invalit
 token given
To:     Jakub Witowski <jakub.witowski@silvair.com>
Cc:     linux-bluetooth@vger.kernel.org,
        Inga Stotland <inga.stotland@intel.com>,
        Brian Gix <brian.gix@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Jakub,

You have commit message typo "invalit".


=C5=9Br., 19 cze 2019 o 09:49 Jakub Witowski <jakub.witowski@silvair.com> n=
apisa=C5=82(a):
>
> This removes NotFound error from mesh-api.txt from Leave() function.
btw. what is the purpose of this patch (or why is this needed) ? since
commit message describes what can be easily read from code diff.
> ---
>  doc/mesh-api.txt | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/doc/mesh-api.txt b/doc/mesh-api.txt
> index 2a800468b..c82732d2c 100644
> --- a/doc/mesh-api.txt
> +++ b/doc/mesh-api.txt
> @@ -112,8 +112,6 @@ Methods:
>                 identified by the 64-bit token parameter. The token param=
eter
>                 has been obtained as a result of successful Join() method=
 call.
>
> -               PossibleErrors:
> -                       org.bluez.mesh.Error.NotFound
>
>         uint64 token CreateNetwork(object app_root, array{byte}[16] uuid)
>
> --
> 2.20.1
>
Regards,
Grzegorz