Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "=?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek" 
        <michal.lowas-rzechonek@silvair.com>
Date:   Thu, 27 Jun 2019 21:56:51 +0200
To:     Inga Stotland <inga.stotland@intel.com>
Cc:     linux-bluetooth@vger.kernel.org, brian.gix@intel.com,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com
Subject: Re: [PATCH BlueZ 2/4] mesh: Fix virtual address processing
Message-ID: <20190627195651.7cilfv7aswyobdk4@kynes>
Mail-Followup-To: Inga Stotland <inga.stotland@intel.com>,
        linux-bluetooth@vger.kernel.org, brian.gix@intel.com,
        johan.hedberg@gmail.com, luiz.dentz@gmail.com
References: <20190627033320.8898-1-inga.stotland@intel.com>
 <20190627033320.8898-3-inga.stotland@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190627033320.8898-3-inga.stotland@intel.com>
User-Agent: NeoMutt/20180716
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Inga,

On 06/26, Inga Stotland wrote:
> diff --git a/mesh/model.c b/mesh/model.c
> index 9fd3aac6c..219371090 100644
> --- a/mesh/model.c
> +++ b/mesh/model.c
> @@ -55,10 +55,10 @@ struct mesh_model {
>  };
>  
>  struct mesh_virtual {
> -	uint32_t id; /*Identifier of internally stored addr, min val 0x10000 */
> -	uint16_t ota;
> +	uint32_t id; /* Internal ID of a stored virtual addr, min val 0x10000 */
>  	uint16_t ref_cnt;
> -	uint8_t addr[16];
> +	uint16_t v_addr; /* 16-bit virtual address, used in messages */

Maybe nitpicking, but I would call this field just 'addr'.

regards
-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND