Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "=?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek" 
        <michal.lowas-rzechonek@silvair.com>
Date:   Sat, 29 Jun 2019 10:34:34 +0200
To:     Inga Stotland <inga.stotland@intel.com>
Cc:     linux-bluetooth@vger.kernel.org, brian.gix@intel.com
Subject: Re: [PATCH BlueZ 2/4 v3] mesh: Fix virtual address processing
Message-ID: <20190629083434.edok7cdjwsjt4d7i@kynes>
Mail-Followup-To: Inga Stotland <inga.stotland@intel.com>,
        linux-bluetooth@vger.kernel.org, brian.gix@intel.com
References: <20190628230142.16367-1-inga.stotland@intel.com>
 <20190628230142.16367-3-inga.stotland@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190628230142.16367-3-inga.stotland@intel.com>
User-Agent: NeoMutt/20180716
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Inga,

On 06/28, Inga Stotland wrote:
> +static struct mesh_virtual *add_virtual(const uint8_t *v)
> +{
> +	struct mesh_virtual *virt = l_queue_find(mesh_virtuals,
> +						find_virt_by_label, v);
> +
> +	if (virt) {
> +		virt->ref_cnt++;
> +		return virt;
> +	}
> +
> +	virt = l_new(struct mesh_virtual, 1);
> +
> +	if (!mesh_crypto_virtual_addr(v, &virt->addr)) {
> +		l_free(virt);
> +		return NULL;
> +	}
> +
> +	memcpy(virt->label, v, 16);
> +	virt->ref_cnt++;

I am aware that l_new zeroes the allocated object, but I think it would
be clearer to say "virt->ref_cnt = 1" here.

Sorry I didn't catch that earlier.

Otherwise, the patchset LGTM.

reagrds
-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND