Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Gix, Brian" <brian.gix@intel.com>
To:     Michal Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
CC:     "Stotland, Inga" <inga.stotland@intel.com>
Subject: RE: [PATCH BlueZ 2/2] mesh: Register D-Bus management interface
Thread-Topic: [PATCH BlueZ 2/2] mesh: Register D-Bus management interface
Thread-Index: AQHVLYteDVrKNOM1e0mwB1SM8/Jqe6a2L5hw
Date:   Mon, 1 Jul 2019 19:44:14 +0000
Message-ID: <DEBB0CAA2616974FAE35E4B560B9A4376CBB5340@ORSMSX103.amr.corp.intel.com>
References: <20190628082734.18809-1-michal.lowas-rzechonek@silvair.com>
 <20190628082734.18809-2-michal.lowas-rzechonek@silvair.com>
In-Reply-To: <20190628082734.18809-2-michal.lowas-rzechonek@silvair.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Applied, Thanks.

> -----Original Message-----
> From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
> owner@vger.kernel.org] On Behalf Of Michal Lowas-Rzechonek
> Sent: Friday, June 28, 2019 1:28 AM
> To: linux-bluetooth@vger.kernel.org
> Cc: Stotland, Inga <inga.stotland@intel.com>
> Subject: [PATCH BlueZ 2/2] mesh: Register D-Bus management interface
> 
> When application Attach()es itself, start exposing both Node1 and
> Management1 D-Bus interfaces.
> ---
>  mesh/node.c | 17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/mesh/node.c b/mesh/node.c
> index 45383b7d5..a2ac747a1 100644
> --- a/mesh/node.c
> +++ b/mesh/node.c
> @@ -259,9 +259,14 @@ static void free_node_resources(void *data)
>  	if (node->disc_watch)
>  		l_dbus_remove_watch(dbus_get_bus(), node->disc_watch);
> 
> -	if (node->path)
> +	if (node->path) {
>  		l_dbus_object_remove_interface(dbus_get_bus(), node->path,
> 
> 	MESH_NODE_INTERFACE);
> +
> +		l_dbus_object_remove_interface(dbus_get_bus(), node->path,
> +
> MESH_MANAGEMENT_INTERFACE);
> +	}
> +
>  	l_free(node->path);
> 
>  	l_free(node);
> @@ -434,6 +439,7 @@ void node_cleanup_all(void)  {
>  	l_queue_destroy(nodes, cleanup_node);
>  	l_dbus_unregister_interface(dbus_get_bus(),
> MESH_NODE_INTERFACE);
> +	l_dbus_unregister_interface(dbus_get_bus(),
> +MESH_MANAGEMENT_INTERFACE);
>  }
> 
>  bool node_is_provisioned(struct mesh_node *node) @@ -1024,7 +1030,11
> @@ static bool register_node_object(struct mesh_node *node)
>  								"%s", uuid);
> 
>  	if (!l_dbus_object_add_interface(dbus_get_bus(), node->path,
> -					MESH_NODE_INTERFACE, node))
> +						MESH_NODE_INTERFACE,
> node))
> +		return false;
> +
> +	if (!l_dbus_object_add_interface(dbus_get_bus(), node->path,
> +					MESH_MANAGEMENT_INTERFACE,
> node))
>  		return false;
> 
>  	return true;
> @@ -1046,6 +1056,9 @@ static void app_disc_cb(struct l_dbus *bus, void
> *user_data)
>  	if (node->path) {
>  		l_dbus_object_remove_interface(dbus_get_bus(), node->path,
> 
> 	MESH_NODE_INTERFACE);
> +
> +		l_dbus_object_remove_interface(dbus_get_bus(), node->path,
> +
> 	MESH_MANAGEMENT_INTERFACE);
>  		l_free(node->app_path);
>  		node->app_path = NULL;
>  	}
> --
> 2.19.1