Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 03 Jul 2019 07:15:49 +0530
User-Agent: K-9 Mail for Android
In-Reply-To: <20190630221408.8509-1-pbrobinson@gmail.com>
References: <20190630221408.8509-1-pbrobinson@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH] Bluetooth: btsdio: Do not bind to non-removable BCM4356
To:     Peter Robinson <pbrobinson@gmail.com>,
        Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org
From:   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Message-ID: <D78E9769-8AFA-4BA1-AF16-CE4E4F08B14A@linaro.org>
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Peter,

On 1 July 2019 3:44:08 AM IST, Peter Robinson <pbrobinson@gmail=2Ecom> wro=
te:
>BCM4356 devices soldered onto the PCB (non-removable) use an UART
>connection for bluetooth, such as the Rock960, but it also advertise
>btsdio support as a sdio function=2E

Sorry, I don't get the point of this patch=2E What if BCM4356 is used in d=
ifferent configuration on some other platform (using SDIO for Bluetooth but=
 still soldered on the PCB)? I haven't seen any such but just curious what =
if!

Thanks,
Mani
>
>Signed-off-by: Peter Robinson <pbrobinson@gmail=2Ecom>
>CC: Manivannan Sadhasivam <manivannan=2Esadhasivam@linaro=2Eorg>
>---
> drivers/bluetooth/btsdio=2Ec | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/bluetooth/btsdio=2Ec b/drivers/bluetooth/btsdio=2Ec
>index 83748b7b2033=2E=2Efd9571d5fdac 100644
>--- a/drivers/bluetooth/btsdio=2Ec
>+++ b/drivers/bluetooth/btsdio=2Ec
>@@ -286,6 +286,7 @@ static int btsdio_probe(struct sdio_func *func,
> 		switch (func->device) {
> 		case SDIO_DEVICE_ID_BROADCOM_43341:
> 		case SDIO_DEVICE_ID_BROADCOM_43430:
>+		case SDIO_DEVICE_ID_BROADCOM_4356:
> 			return -ENODEV;
> 		}
> 	}

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E