Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2122035ybi; Thu, 4 Jul 2019 05:34:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqzDsn7IzVABUvo3WBXc8/4pw07zPIFziXBJDxYkbrmKVGel1V7mfdGDcdU62LKl5oPkWuG+ X-Received: by 2002:a17:90a:21ac:: with SMTP id q41mr19868827pjc.31.1562243666679; Thu, 04 Jul 2019 05:34:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562243666; cv=none; d=google.com; s=arc-20160816; b=oinvgpcossxmY/PvwRepa5+Jse3ic2oIso3mUDz9/5TiGKWV1NG+MYEnxTLgHvRJ6S t+SQE8jPW5lPpAn0CDNL8ZDVbTJs8TaBvB31KMtcXGAR/Rj33qBaA020A65/Z9eT59MZ AxFcOkSJnf7oGPRYZiNKB58lRJCjmxccSg/KGJH2ZDM7zrDcXKWutqJkeAeFym2u70Mn CnXhuzoHCqB0i03QMLFu5FQD2vs+PmCFbetiB0kvI7ADmlHxCHkkl6Q7qw3xe6nW15DG 7CY/dUc1TPcjMVc0mcjSfUaGYMrGw2vNmCXjv7+0eFL6irmvC+4SO/sVOJABN5ojTi7G mTqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zlw8L5+yskUSC4tHVm2lBZcPGopq19rqAKLUeoXmxvo=; b=d0GD/Pi9Pdev3775E+7lbci/sQnoSCRC+8jh7rybnBHMOqHEcSBCuu8KcrV/IHi7Ge tw6lJEQc7zqFfbtrr7T8jnE1n0AyAEolOUL2m3kKoA9WFZZGQc3ezCL4FHV2zfZDKloP La7dfsoyA19xKdW32WS2tyi3PSCzBiGaLd/IJEva4YWkYJEYVHn9eOrZzWO5QGyaiQlF 3OvPv4ImY/RhZpd1OE9fTOB9+tSniMK+7Jewk3obay2wyP4PATaVZdlnkTXQTHbTu13S QLZpNlI6HsSEnLLfpP0WkmpQqKpHRJ0hDGoS+eAcLGNk4vhUHOLDFbNs65/INAsRyffL ORoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=g15GhW3x; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 21si5406266pfo.138.2019.07.04.05.34.05; Thu, 04 Jul 2019 05:34:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@silvair-com.20150623.gappssmtp.com header.s=20150623 header.b=g15GhW3x; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727698AbfGDMdr (ORCPT + 99 others); Thu, 4 Jul 2019 08:33:47 -0400 Received: from mail-lj1-f178.google.com ([209.85.208.178]:42512 "EHLO mail-lj1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727768AbfGDMdr (ORCPT ); Thu, 4 Jul 2019 08:33:47 -0400 Received: by mail-lj1-f178.google.com with SMTP id t28so5988658lje.9 for ; Thu, 04 Jul 2019 05:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silvair-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zlw8L5+yskUSC4tHVm2lBZcPGopq19rqAKLUeoXmxvo=; b=g15GhW3xaff0syWftJzjBVevBcvoL4e+AHWLhKjL7BWV+hQewrQYW48TzhLVToSpZn Z5BBZYzlmdfXSU4akXbtLMjRhdZ1r5oZFQ1V0r5i7Es2raVGHcXNGaIbYQHaBBxNxcxo MJEE4B0aQgGbeJs/nTwO3PAjFwBencb+tNWXq1uTXbQ35QbA0iXvRdfgRo/ZWhuH4rNf At9hBpEPtva1K8eFHJyxjaFdKddXD8UxqvL8CmjjL4N0Dgt58rMFDcbW6Tu54KbGc6Lq TC/H47me+UkW2BOXe6R+/mcNAQ9vInhW0eiIa6ptDhlkK+An0CqX163YGdRUtRverLzF XM4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zlw8L5+yskUSC4tHVm2lBZcPGopq19rqAKLUeoXmxvo=; b=BPGVdTGkJszP1sj1x6WdOwe5MrOJB+Y5yfUzD+jmfhjlXa44b+VfMGCTuu+uyw6LZR g9FRnFSbHHyN4LmYHdbmIWC9DpTmT0KwsEkzfz7cqVf8kHpzwMPF1IgddOLAr7QNSUTT Y7lGKeg1AMP7x7btqTnoCMCcNhoFAcSy/4p+EwUo5ba7MrmN2zioLyeBFJS1UxfFJhqS RKmkIaXZ6PQDCc6ttFOdCNMkP526vSrFkRN7juGcZ+rDxAsEH2zwB1lp4+YDKNzI95NX NyjgYIDcuBEjbPlw1cFJu7YB5LvUkqD2AzpwV9tqcR/DovCnOFtMXP6jP9lD9MdDERcG wWHA== X-Gm-Message-State: APjAAAWFrT7dzkeRzewwQSQTHTSO3TXsaKHuN9SP7x1ctzwkvIqPrPvX SuGPbryNvpl521KVx7U31DoaImkVkuk= X-Received: by 2002:a2e:298a:: with SMTP id p10mr24159244ljp.74.1562243625490; Thu, 04 Jul 2019 05:33:45 -0700 (PDT) Received: from mlowasrzechonek2133.silvair.lan ([217.153.94.18]) by smtp.gmail.com with ESMTPSA id g68sm1126151ljg.47.2019.07.04.05.33.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 04 Jul 2019 05:33:44 -0700 (PDT) From: =?UTF-8?q?Micha=C5=82=20Lowas-Rzechonek?= To: linux-bluetooth@vger.kernel.org Cc: Inga Stotland Subject: [PATCH BlueZ v5 2/5] mesh: Cleanup D-Bus method returns with empty result Date: Thu, 4 Jul 2019 14:33:35 +0200 Message-Id: <20190704123338.5988-3-michal.lowas-rzechonek@silvair.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190704123338.5988-1-michal.lowas-rzechonek@silvair.com> References: <20190704123338.5988-1-michal.lowas-rzechonek@silvair.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org --- mesh/node.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/mesh/node.c b/mesh/node.c index 1dcb74b4f..53876ef5a 100644 --- a/mesh/node.c +++ b/mesh/node.c @@ -1949,7 +1949,6 @@ static struct l_dbus_message *send_call(struct l_dbus *dbus, uint16_t dst, app_idx, src; uint8_t *data; uint32_t len; - struct l_dbus_message *reply; l_debug("Send"); @@ -1978,10 +1977,7 @@ static struct l_dbus_message *send_call(struct l_dbus *dbus, mesh_net_get_default_ttl(node->net), data, len)) return dbus_error(msg, MESH_ERROR_FAILED, NULL); - reply = l_dbus_message_new_method_return(msg); - l_dbus_message_set_arguments(reply, ""); - - return reply; + return l_dbus_message_new_method_return(msg); } static struct l_dbus_message *publish_call(struct l_dbus *dbus, @@ -1995,7 +1991,6 @@ static struct l_dbus_message *publish_call(struct l_dbus *dbus, struct node_element *ele; uint8_t *data; uint32_t len; - struct l_dbus_message *reply; int result; l_debug("Publish"); @@ -2027,10 +2022,7 @@ static struct l_dbus_message *publish_call(struct l_dbus *dbus, if (result != MESH_ERROR_NONE) return dbus_error(msg, result, NULL); - reply = l_dbus_message_new_method_return(msg); - l_dbus_message_set_arguments(reply, ""); - - return reply; + return l_dbus_message_new_method_return(msg); } static struct l_dbus_message *vendor_publish_call(struct l_dbus *dbus, @@ -2046,7 +2038,6 @@ static struct l_dbus_message *vendor_publish_call(struct l_dbus *dbus, struct node_element *ele; uint8_t *data = NULL; uint32_t len; - struct l_dbus_message *reply; int result; l_debug("Publish"); @@ -2079,10 +2070,7 @@ static struct l_dbus_message *vendor_publish_call(struct l_dbus *dbus, if (result != MESH_ERROR_NONE) return dbus_error(msg, result, NULL); - reply = l_dbus_message_new_method_return(msg); - l_dbus_message_set_arguments(reply, ""); - - return reply; + return l_dbus_message_new_method_return(msg); } static void setup_node_interface(struct l_dbus_interface *iface) -- 2.19.1