Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 10 Jul 2019 17:01:23 +0200
From:   =?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek 
        <michal.lowas-rzechonek@silvair.com>
To:     Inga Stotland <inga.stotland@intel.com>,
        linux-bluetooth@vger.kernel.org, brian.gix@intel.com,
        jakub.witowski@silvair.com
Subject: Re: [PATCH BlueZ 4/9] mesh: Generalize mesh-config APIs
Message-ID: <20190710150123.veutvrmbhx5v7phg@kynes>
Mail-Followup-To: Inga Stotland <inga.stotland@intel.com>,
        linux-bluetooth@vger.kernel.org, brian.gix@intel.com,
        jakub.witowski@silvair.com
References: <20190710050959.7321-1-inga.stotland@intel.com>
 <20190710050959.7321-5-inga.stotland@intel.com>
 <20190710073827.5ktzlyynztmebiv6@mlowasrzechonek2133>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190710073827.5ktzlyynztmebiv6@mlowasrzechonek2133>
User-Agent: NeoMutt/20180716
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On 07/10, Michał Lowas-Rzechonek wrote:
> mesh-config.h:
>     union mesh_config;
> 
>     union mesh_config *mesh_config_create_config(void);
>     void mesh_config_release_config(union mesh_config *config);
> 
> mesh-config-json.c:
>     union mesh_config {
>         json_object *json
>     };
> 
>     union mesh_config *mesh_config_create_config(void)
>     {
>         return (union mesh_config*)json_object_new_object();
>     }
> 
>     void mesh_config_release_config(union mesh_config *cfg)
>     {
>         json_object *jnode = (json_object *)cfg;
> 
>         if (!cfg)
>             return;
> 
>         json_object_put(jnode);
>     }

Or even simpler, since we don't even need to define the mesh_config:

mesh-config.h
    struct mesh_config;

    struct mesh_config *mesh_config_create_config(void);
    void mesh_config_release_config(struct mesh_config *config);

    struct mesh_config *mesh_config_create_config(void)
    {
        return (struct mesh_config*)json_object_new_object();
    }

    void mesh_config_release_config(struct mesh_config *cfg)
    {
        json_object *jnode = (json_object *)cfg;
    }

-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND