Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp10132693ybi; Thu, 11 Jul 2019 00:07:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqzi5TW/VYw7lmi7+dZ0I8eKVxtJvDvC9VWGKTv8dDgTrKBH+Ofe95TOAguPYVutLY716ohp X-Received: by 2002:a17:90a:30aa:: with SMTP id h39mr3102730pjb.32.1562828825736; Thu, 11 Jul 2019 00:07:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562828825; cv=none; d=google.com; s=arc-20160816; b=E/5QagkDOX+PkIBt1ySvwEo+lN5dS1MX2nX51uTr4qHI9ZzjqKs03WoDVoCkojsFBO 27GLd0SuKqTeqi/mWpuGW4h13ZtyrjjqVsaEha5zb3kWwgNwKz54d/TrcIF5erxkLV9m Mbp1FYx5MxzoJ/fCPMXIsxLN5Ay1/jqR4Jc8+Kk8VqWhCOiG8ITuGvRohHE2VMclExlA TQjhRSzUVETZ8+j60p/EB4FdhzHvNN2jHUzCmHgzAECQ9GB0qJNrXYagEhyUeilp9R4N lqV8VuH7pZgMICmfTKmuk99xANiwn1JIHMyNeshOnn92JkQHiiHR/ceLF5hqeHqxjMI0 iKrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=5UdYZdwVtfJFoUJ9Fwuy1mqrHkX97TvRSq1C60be4lU=; b=O7PPWzB52EAB7NioAW3rOSN2xWV5w4f3dbJnEC8fAzkTMA8DnQ9u2ROKOaOebTUScF 48lggVIjt/SxeClYU9rZm8ILkwKiOErR+fgobxINdChvESaZaeJqiVO34H5DvRKWHIRh 2nZ93TMXmX31IhPAHaqSe3EplM0cCXwqpzNYrPT5p8s+by6FzeOpj0z6nrYwT7c031Ur lHWWiSZVbPPU1z52p5eYVXAk1SMmSyz0V16OCS4sk62jNIbXa9B1Y57LHNqH2d66qVo5 YHdKSEu6GougbiSFj86IDoQp2+oWvRIfCtS41PCzoU8+1PxNBTdf3IW0z7Dk0kk5Zz0U Lwtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f96si4147342plb.339.2019.07.11.00.06.50; Thu, 11 Jul 2019 00:07:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728154AbfGKHF3 convert rfc822-to-8bit (ORCPT + 99 others); Thu, 11 Jul 2019 03:05:29 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:60750 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728142AbfGKHF2 (ORCPT ); Thu, 11 Jul 2019 03:05:28 -0400 Received: from [192.168.23.168] (unknown [157.25.100.178]) by mail.holtmann.org (Postfix) with ESMTPSA id B8EAACF2B8; Thu, 11 Jul 2019 09:13:59 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH -next] Bluetooth: btusb: Fix error return code in btusb_mtk_setup_firmware() From: Marcel Holtmann In-Reply-To: <20190710061222.141247-1-weiyongjun1@huawei.com> Date: Thu, 11 Jul 2019 09:05:25 +0200 Cc: Johan Hedberg , Matthias Brugger , Sean Wang , Linux Bluetooth mailing list , linux-arm-kernel , linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <44F125E4-F492-4F33-9E50-F10CE11C09BC@holtmann.org> References: <20190710061222.141247-1-weiyongjun1@huawei.com> To: Wei Yongjun X-Mailer: Apple Mail (2.3445.104.11) Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Wei, > Fix to return error code -EINVAL from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: a1c49c434e15 ("Bluetooth: btusb: Add protocol support for MediaTek MT7668U USB devices") > Signed-off-by: Wei Yongjun > --- > drivers/bluetooth/btusb.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel