Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Szymon Janc <szymon.janc@codecoup.pl>
To:     Bastien Nocera <hadess@hadess.net>
Cc:     linux-bluetooth@vger.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH] input/hog: Remove HID device after HoG device disconnects
Date:   Mon, 15 Jul 2019 14:51:44 +0200
Message-ID: <1623552.bYGA88Ch3a@ix>
Organization: CODECOUP
In-Reply-To: <20190614153125.2605-1-hadess@hadess.net>
References: <20190614153125.2605-1-hadess@hadess.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi,

On Friday, 14 June 2019 17:31:25 CEST Bastien Nocera wrote:
> From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> 
> When the Bluetooth LE device disconnects, make sure to also destroy the
> uHID device so that we don't have a lingering HID device accessible from
> user-space.
> 
> This also fixes the input subsystem never seeing the device reattaching,
> causing settings that should be applied on connection not to be applied.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=202909
> 
> Tested-by: Bastien Nocera <hadess@hadess.net>
> ---
>  profiles/input/hog.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/profiles/input/hog.c b/profiles/input/hog.c
> index 23c9c1529..83c017dcb 100644
> --- a/profiles/input/hog.c
> +++ b/profiles/input/hog.c
> @@ -199,6 +199,8 @@ static int hog_disconnect(struct btd_service *service)
>  	struct hog_device *dev = btd_service_get_user_data(service);
> 
>  	bt_hog_detach(dev->hog);
> +	bt_hog_unref(dev->hog);
> +	dev->hog = NULL;
> 
>  	btd_service_disconnecting_complete(service, 0);

I've tested this with device I have and introduced delay is acceptable imho.
Since this fix end-user usabiblity for some of the devices on the market I 
think the trade-off is justified.

Patch is now applied.

-- 
pozdrawiam
Szymon Janc