Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "=?utf-8?Q?Micha=C5=82?= Lowas-Rzechonek" 
        <michal.lowas-rzechonek@silvair.com>
Date:   Thu, 18 Jul 2019 10:59:23 +0200
To:     Inga Stotland <inga.stotland@intel.com>
Cc:     linux-bluetooth@vger.kernel.org, brian.gix@intel.com
Subject: Re: [PATCH BlueZ] mesh: Init keyring storage directory on node
 Attach()
Message-ID: <20190718085923.4ljvk3t3avqdh24d@mlowasrzechonek2133>
Mail-Followup-To: Inga Stotland <inga.stotland@intel.com>,
        linux-bluetooth@vger.kernel.org, brian.gix@intel.com
References: <20190718040126.5152-1-inga.stotland@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190718040126.5152-1-inga.stotland@intel.com>
User-Agent: NeoMutt/20180716
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

On 07/17, Inga Stotland wrote:
>This adds initialization of keyring storage directory when
>a mesh node is attached successfully.
>---
> mesh/node.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/mesh/node.c b/mesh/node.c
>index 652551756..6b784bf8d 100644
>--- a/mesh/node.c
>+++ b/mesh/node.c
>@@ -1656,6 +1656,14 @@ static void get_managed_objects_cb(struct l_dbus_message *msg, void *user_data)
> 		} else
> 			goto fail;
>
>+		/*
>+		 * TODO: For now always initialize directory for storing
>+		 * keyring info. Need to figure out what checks need
>+		 * to be performed to do this conditionally, i.e., presence of
>+		 * Provisioner interface, etc.
>+		 */
>+		init_storage_dir(node);

I think the keyring should be initialized as soon ad the node is 
created. The keyring should always exist, and should contain at least 
the local device key - otherwise DevKeySend can't be used to talk to 
local Config Server.

-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND