Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 24 Jul 2019 21:12:41 +0200
From:   "michal.lowas-rzechonek@silvair.com" 
        <michal.lowas-rzechonek@silvair.com>
To:     "Stotland, Inga" <inga.stotland@intel.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ v2 2/5] mesh: Validate application by comparing
 composition data
Message-ID: <20190724191241.ad4vri23hs2zqyce@kynes>
Mail-Followup-To: "Stotland, Inga" <inga.stotland@intel.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
References: <20190723100623.6957-1-michal.lowas-rzechonek@silvair.com>
 <20190723100623.6957-3-michal.lowas-rzechonek@silvair.com>
 <164c441cf7b43a1be420444676417f77f88a86c4.camel@intel.com>
 <20190724075511.elmqslt5kb3u3p2m@mlowasrzechonek2133>
 <d880777698581163febad448e8b71c69ab4c0580.camel@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d880777698581163febad448e8b71c69ab4c0580.camel@intel.com>
User-Agent: NeoMutt/20180716
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi Inga,

On 07/24, Stotland, Inga wrote:
> > > So here, prior to removing the temorary node, the element paths
> > > need to be copied into the "req->attach" version of the node.
> > > Same goes for node->agent and node->provisioner.	
> > 
> > True, thanks! I'll fix this in v3.
> 
> Also, could you please add some comment there, like "Deleting the
> temporary node" just to make the point that tit was temporary? I am
> afraid that for an outside person this will not be clear why the node
> is being removed.

Sure thing.

> > > "Location" property is described as optional in mesh-api.txt. It's
> > > populated with "Default Location", if the property is not present.
(...)
> Let's try to keep it as optional then.

Will do.

> This will require some *fuzzy* matching of the composition data,
> something like:
> add a boolean flag to generate_node_composition() that indicates
> whether the composition is generated for the verification or as a
> result of an external request, i.e. for the config server model. Based
> on the flag, either include location field, or not.

I don't think I follow. If the application doesn't provide the
"Location" property, everything behaves as if it provided it with value
"0", no?

Location descriptor is *not* optional in Composition Data (Table 4.4 in
section 4.2.1.1).


-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@silvair.com>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND