Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
From:   =?UTF-8?B?UmFmYcWCIEdhamRh?= <rafal.gajda@silvair.com>
Date:   Mon, 29 Jul 2019 14:11:25 +0200
Message-ID: <CAFcXi1yYYNv3T-0UtFGf_n91hHBvShxuWJdCVhUpdBf6grRP2w@mail.gmail.com>
Subject: Mesh daemon to watch InterfacesRemoved signals
To:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-bluetooth-owner@vger.kernel.org
Precedence: bulk

Hi all,

At the moment after connecting an app, mesh daemon only watches for
that app disconnecting from D-Bus with:
node->disc_watch =3D l_dbus_add_disconnect_watch(bus,
node->owner, app_disc_cb, node, NULL);

in node.c::get_managed_objects_cb

I can unregister all of the app interfaces (leaving it non functional
but still connected to D-Bus) and mesh daemon will not be aware of
that, still trying to communicate with it.
This is especially problematic if app stops functioning correctly, but
daemon continues to call its methods i.e. when a message is received.

Maybe it would be beneficial for mesh daemon to listen to
InterfacesRemoved signals to determine when apps/nodes disconnect:

signal time=3D1564398245.483028 sender=3D:1.6219 -> destination=3D(null
destination) serial=3D27 path=3D/com/silvair/application;
interface=3Dorg.freedesktop.DBus.ObjectManager; member=3DInterfacesRemoved
   object path "/com/silvair/application"
   array [
      string "org.mesh daemon.mesh.Application1"
      string "org.mesh daemon.mesh.ProvisionAgent1"
   ]
signal time=3D1564398245.483133 sender=3D:1.6219 -> destination=3D(null
destination) serial=3D28 path=3D/com/silvair/application/element0;
interface=3Dorg.freedesktop.DBus.ObjectManager; member=3DInterfacesRemoved
   object path "/com/silvair/application/element0"
   array [
      string "org.mesh daemon.mesh.Element1"
   ]


This would give applications ability to, for example, have a multiple
nodes registered and remove/change some of them without whole app
restarting.


Best Regards

--=20

Rafa=C5=82 Gajda

Silvair Sp. z o.o.
Jasnog=C3=B3rska 44
31-358 Krakow
POLAND

www.silvair.com

NOTICE TO RECIPIENT

We inform you that Silvair sp. z o.o. with its registered office in
Cracow (31-358), at Jasnog=C3=B3rska Street 44 is the controller of your
personal data. You can find more information about processing personal
data and your rights here.


Informujemy, =C5=BCe administratorem Twoich danych jest Silvair sp. z o.o.
z siedzib=C4=85 w Krakowie  (31-358), ul. Jasnog=C3=B3rska 44. Wi=C4=99cej =
informacji
na temat przetwarzania danych osobowych i przys=C5=82uguj=C4=85cych Ci praw
znajdziesz tu


This e-mail message and any documents accompanying it contain
information that belongs to SILVAIR. This e-mail is meant for only the
intended recipient of the transmission and may be a communication
privileged by law, confidential and/or otherwise protected from
disclosure. If you received this e-mail in error and you are not the
intended recipient, any review, use, dissemination, distribution, or
copying of this e-mail or attachment is strictly prohibited. Please
notify us immediately of the error by return e-mail and please delete
this message from your system.