Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp6847103ybi; Wed, 31 Jul 2019 22:59:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqyVRs7uEXgAp4+MS+JeghyGx+X6KEcdPLjW+LagZzCeP+0Rhdo1Rzvf/6M3AhJXnkDSO88G X-Received: by 2002:a63:5a0a:: with SMTP id o10mr44735063pgb.282.1564639143447; Wed, 31 Jul 2019 22:59:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564639143; cv=none; d=google.com; s=arc-20160816; b=Vu7EF6GxtQPL+kjEIZSFE7wJn56D5PhrcTyieHtBFcErYNObsMeip8uMpGh8mEwoi6 Eb4kIx0UFqi13H1Yw8KAdYckuoOLA4ujiCKOqG5VBWN+l2ZQ0m8ddVFlod101ifXGO+k igaPxxrcjLOAIvepP3QO9Ruo93gsZ9LjNBnyRDUZtDNDVgg7xd2AuiLHycCL3U5ytaOd b1gkKZtuPPmBBj7dEmmNzXZfaodZMNGd89hahSzNgk+ZcIt4znATwEXKwuNX5Fb9/nXn 9nWYweIat0V5p/r6cz4mF1MjXUsbmV745+FYqT9koNR2dFtin1OHyfajoFyUUgJS+Ox7 r7Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=gVscaO8qiM1kjQj666Oxeby5/oIPr4jVOlOzvxgYpsY=; b=csHN3IXNW+8bzRM8I1V9hBAhe29N7XGo87LmWH8yIklx72nRewl4dAnO2iiolDGPAM 7RRyBl3JQY7KUwwzeeYPJIQgC4xeWG/i565rJZkZ8ilL9BCATOf2hxGFcBK8ihqJNGcb gHV22zRa+4dZGewUK3hI82irLqzoFOFEWgeIJQIHOmOwViGXteURP7Pn1koYmQBDzprD U3YiTbRBeGLQ2Ljf5G8U2Ld2652vo4OWe9nBKL+wpbj/F43VDZ193deFLPqAP2DJJ+CJ v8nxCYx59CdSf4hxXAtBwuW2ifXlxtgq7IcO/7eQSAHh/J3ytyHKfryptQhNdEyMb5ss MXUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t19si31620827plo.376.2019.07.31.22.58.49; Wed, 31 Jul 2019 22:59:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729072AbfHAFsE (ORCPT + 99 others); Thu, 1 Aug 2019 01:48:04 -0400 Received: from mga09.intel.com ([134.134.136.24]:55601 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728702AbfHAFsE (ORCPT ); Thu, 1 Aug 2019 01:48:04 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 22:48:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,333,1559545200"; d="p7s'?scan'208";a="324112340" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga004.jf.intel.com with ESMTP; 31 Jul 2019 22:48:03 -0700 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 31 Jul 2019 22:48:03 -0700 Received: from orsmsx103.amr.corp.intel.com ([169.254.5.29]) by ORSMSX157.amr.corp.intel.com ([169.254.9.94]) with mapi id 14.03.0439.000; Wed, 31 Jul 2019 22:48:03 -0700 From: "Stotland, Inga" To: "michal.lowas-rzechonek@silvair.com" , "linux-bluetooth@vger.kernel.org" CC: "Gix, Brian" Subject: Re: [PATCH BlueZ v7 0/3] Implement org.bluez.mesh.Network1.Import() D-Bus API Thread-Topic: [PATCH BlueZ v7 0/3] Implement org.bluez.mesh.Network1.Import() D-Bus API Thread-Index: AQHVR2/6O5tSpVd2TUCJPT/oS66+xabmP9UA Date: Thu, 1 Aug 2019 05:48:02 +0000 Message-ID: References: <20190731071647.27217-1-michal.lowas-rzechonek@silvair.com> In-Reply-To: <20190731071647.27217-1-michal.lowas-rzechonek@silvair.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.254.102.11] Content-Type: multipart/signed; micalg=sha-1; protocol="application/x-pkcs7-signature"; boundary="=-/AMt1Ye0gxmVaxFtg2NI" MIME-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org --=-/AMt1Ye0gxmVaxFtg2NI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Michal, Jakub, On Wed, 2019-07-31 at 09:16 +0200, Micha=C5=82 Lowas-Rzechonek wrote: > + Keep defaultTTL and seqNumber optional, but check the format and > range > + Style fixes in mesh-config-json > + Reworked the API to new signature > + Removed dependencies on mesh-config >=20 >=20 > *** BLURB HERE *** >=20 > Jakub Witowski (1): > mesh: Extract read_* functions in mesh-config-json >=20 > Micha=C5=82 Lowas-Rzechonek (2): > mesh: Add documentation for Import() D-Bus API > mesh: Implement Import() D-Bus API of org.bluez.mesh.Network1 > interface >=20 > doc/mesh-api.txt | 57 ++++++++++++++------ > mesh/mesh-config-json.c | 83 +++++++++++++++++++++++------ > mesh/mesh.c | 115 > +++++++++++++++++++++++++++++++++++++++- > mesh/node.c | 87 +++++++++++++++++++++++++++++- > mesh/node.h | 5 ++ > 5 files changed, 314 insertions(+), 33 deletions(-) >=20 The patch set looks good. Regards, Inga --=-/AMt1Ye0gxmVaxFtg2NI Content-Type: application/x-pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIKbDCCBOsw ggPToAMCAQICEDabxALowUBS+21KC0JI8fcwDQYJKoZIhvcNAQEFBQAwbzELMAkGA1UEBhMCU0Ux FDASBgNVBAoTC0FkZFRydXN0IEFCMSYwJAYDVQQLEx1BZGRUcnVzdCBFeHRlcm5hbCBUVFAgTmV0 d29yazEiMCAGA1UEAxMZQWRkVHJ1c3QgRXh0ZXJuYWwgQ0EgUm9vdDAeFw0xMzEyMTEwMDAwMDBa Fw0yMDA1MzAxMDQ4MzhaMHkxCzAJBgNVBAYTAlVTMQswCQYDVQQIEwJDQTEUMBIGA1UEBxMLU2Fu dGEgQ2xhcmExGjAYBgNVBAoTEUludGVsIENvcnBvcmF0aW9uMSswKQYDVQQDEyJJbnRlbCBFeHRl cm5hbCBCYXNpYyBJc3N1aW5nIENBIDRCMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA yzuW/y/g0bznz8BD48M94luFzqHaqY9yGN9H/W0J7hOVBpl0rTQJ6kZ7z7hyDb9kf2UW4ZU25alC i+q5m6NwHg+z9pcN7bQ84SSBueaYF7cXlAg7z3XyZbzSEYP7raeuWRf5fYvYzq8/uI7VNR8o/43w PtDP10YDdO/0J5xrHxnC/9/aU+wTFSVsPqxsd7C58mnu7G4VRJ0n9PG4SfmYNC0h/5fLWuOWhxAv 6MuiK7MmvTPHLMclULgJqVSqG1MbBs0FbzoRHne4Cx0w6rtzPTrzo+bTRqhruaU18lQkzBk6OnyJ UthtaDQIlfyGy2IlZ5F6QEyjItbdKcHHdjBX8wIDAQABo4IBdzCCAXMwHwYDVR0jBBgwFoAUrb2Y ejS0Jvf6xCZU7wO94CTLVBowHQYDVR0OBBYEFNpBI5xaj3GvV4M+INPjZdsMywvbMA4GA1UdDwEB /wQEAwIBhjASBgNVHRMBAf8ECDAGAQH/AgEAMDYGA1UdJQQvMC0GCCsGAQUFBwMEBgorBgEEAYI3 CgMEBgorBgEEAYI3CgMMBgkrBgEEAYI3FQUwFwYDVR0gBBAwDjAMBgoqhkiG+E0BBQFpMEkGA1Ud HwRCMEAwPqA8oDqGOGh0dHA6Ly9jcmwudHJ1c3QtcHJvdmlkZXIuY29tL0FkZFRydXN0RXh0ZXJu YWxDQVJvb3QuY3JsMDoGCCsGAQUFBwEBBC4wLDAqBggrBgEFBQcwAYYeaHR0cDovL29jc3AudHJ1 c3QtcHJvdmlkZXIuY29tMDUGA1UdHgQuMCygKjALgQlpbnRlbC5jb20wG6AZBgorBgEEAYI3FAID oAsMCWludGVsLmNvbTANBgkqhkiG9w0BAQUFAAOCAQEAp9XGgH85hk/3IuN8F4nrFd24MAoau7Uq M/of09XtyYg2dV0TIPqtxPZw4813r78WwsGIbvtO8VQ18dNktIxaq6+ym2zebqDh0z6Bvo63jKE/ HMj8oNV3ovnuo+7rGpCppcda4iVBG2CetB3WXbUVr82EzECN+wxmC4H9Rup+gn+t+qeBTaXulQfV TYOvZ0eZPO+DyC2pVv5q5+xHljyUsVqpzsw89utuO8ZYaMsQGBRuFGOncRLEOhCtehy5B5aCI571 i4dDAv9LPODrEzm3PBfrNhlp8C0skak15VXWFzNuHd00AsxXxWSUT4TG8RiAH61Ua5GXsP1BIZwl 4WjK8DCCBXkwggRhoAMCAQICEzMAAHkSbxmcZYXZ3q8AAAAAeRIwDQYJKoZIhvcNAQEFBQAweTEL MAkGA1UEBhMCVVMxCzAJBgNVBAgTAkNBMRQwEgYDVQQHEwtTYW50YSBDbGFyYTEaMBgGA1UEChMR SW50ZWwgQ29ycG9yYXRpb24xKzApBgNVBAMTIkludGVsIEV4dGVybmFsIEJhc2ljIElzc3Vpbmcg Q0EgNEIwHhcNMTkwMzI4MTgzOTA4WhcNMjAwMzIyMTgzOTA4WjBBMRcwFQYDVQQDEw5TdG90bGFu ZCwgSW5nYTEmMCQGCSqGSIb3DQEJARYXaW5nYS5zdG90bGFuZEBpbnRlbC5jb20wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQC2G5M/W8NZAZ4TJB1BMvVCtoUmCavUkUo2lw8xY/EZcyre fgklUGbk5bVeALgRgWOy/STHNpXu+LxzDICt0uPhoVrpz3WPF8akFdIve4IYMZJ3vkFOeiclseLw Yqg3zQTabz5Z1XMx/iq2MJmC8MUdrovdLGNacPM6+dJWVsslFOBO3vuSaypGKXmKdy8vfSIXX6vK f5VlWW2Gi3WRHfuyuWtnEJbkoPLtydTNvBzqLpe8QmcM5wXio8/mZfnPDDWR8I1FO8MWzQF6rG00 k3sf6w6ZKbZbz2V54rncMEXM3N/P4C6ZHZR0XYqh5m1vWxZYYVzTuDEH1C8W+b3KzldrAgMBAAGj ggIwMIICLDAdBgNVHQ4EFgQUcdzZH9M8OSxLujP+AToiD5oYMRkwHwYDVR0jBBgwFoAU2kEjnFqP ca9Xgz4g0+Nl2wzLC9swZQYDVR0fBF4wXDBaoFigVoZUaHR0cDovL3d3dy5pbnRlbC5jb20vcmVw b3NpdG9yeS9DUkwvSW50ZWwlMjBFeHRlcm5hbCUyMEJhc2ljJTIwSXNzdWluZyUyMENBJTIwNEIu Y3JsMIGeBggrBgEFBQcBAQSBkTCBjjAhBggrBgEFBQcwAYYVaHR0cDovL29jc3AuaW50ZWwuY29t MGkGCCsGAQUFBzAChl1odHRwOi8vd3d3LmludGVsLmNvbS9yZXBvc2l0b3J5L2NlcnRpZmljYXRl cy9JbnRlbCUyMEV4dGVybmFsJTIwQmFzaWMlMjBJc3N1aW5nJTIwQ0ElMjA0Qi5jcnQwCwYDVR0P BAQDAgeAMDwGCSsGAQQBgjcVBwQvMC0GJSsGAQQBgjcVCIbDjHWEmeVRg/2BKIWOn1OCkcAJZ4He vTmV8EMCAWQCAQkwHwYDVR0lBBgwFgYIKwYBBQUHAwQGCisGAQQBgjcKAwwwKQYJKwYBBAGCNxUK BBwwGjAKBggrBgEFBQcDBDAMBgorBgEEAYI3CgMMMEsGA1UdEQREMEKgJwYKKwYBBAGCNxQCA6AZ DBdpbmdhLnN0b3RsYW5kQGludGVsLmNvbYEXaW5nYS5zdG90bGFuZEBpbnRlbC5jb20wDQYJKoZI hvcNAQEFBQADggEBALnl11xd+3X6fVS0VAKeoF0jCPLFZLCk4jMFifFzY2md3MLjVIB3lE5ffNnS mjG9ErOO6as95K6D6hzCJMqNodOyVPRSrMNey0tzFAPLRG3s2bgfmOcvYr4O3WmpDMx8YmH6O2YI 3Xxjyp11aXl5pk6VjpZV/hjN1jwZ/c/X00KsjoMB8mGSBvbwnV0EFQUJ99xsAlqQ4edj2T9z6pF1 WX189YL64c/t3a9LWNaT2CWbBZLIFoor9TpZsIj0lGObmGA76JKn5yxN+jzxhWIAzPi5KKYgJ9EU FDn6fGbJHisZdWX3bVamfpmPogThm1khlD7R4USu0eyym3JRh0tXJeAxggIXMIICEwIBATCBkDB5 MQswCQYDVQQGEwJVUzELMAkGA1UECBMCQ0ExFDASBgNVBAcTC1NhbnRhIENsYXJhMRowGAYDVQQK ExFJbnRlbCBDb3Jwb3JhdGlvbjErMCkGA1UEAxMiSW50ZWwgRXh0ZXJuYWwgQmFzaWMgSXNzdWlu ZyBDQSA0QgITMwAAeRJvGZxlhdnerwAAAAB5EjAJBgUrDgMCGgUAoF0wGAYJKoZIhvcNAQkDMQsG CSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMTkwODAxMDU0ODAyWjAjBgkqhkiG9w0BCQQxFgQU RnKZyialLJ1FsvXersrWbWATKvwwDQYJKoZIhvcNAQEBBQAEggEAngF0ndE1fPfGWaJJ6fM+uNoe mJZDDhcS6oQkts0Ec0Qm33zk+WUbh9k9v5QdprwqrK+rGCoHVr0Z17DOsbMNorBUng8Y2UPM1QgR 7bP/43UfH8iWqAm5cpaLe4IzYFnD/4wKCHTs3Fl18oeAnryqCdSJlpV/B4Q9sueGSZJXDBCVxd/b id4P5PWKI9MVavWfNu8aVvCZdBvrMbuGVgtso+haEqfoGgoExVAddwQGHmhjNxPD+QkBCLXV0MAW keT8RbhEYr3LJ6goec4jcxAbjCYaXayucvnRRtfKdSSr/0+nSBk/nQVVrQCOnOu4+Ozm3qPz9f3W 5cgJhmtcmFXjGgAAAAAAAA== --=-/AMt1Ye0gxmVaxFtg2NI--